Re: [PATCH RFC] xfs_spaceman: updated preallocation support (eofblocks v6)

[Brian Foster <bfoster@redhat.com>]

On 11/06/2012 05:43 PM, Dave Chinner wrote:
> On Tue, Nov 06, 2012 at 09:55:04AM -0500, Brian Foster wrote:
>...
>> I can also squash this into the original and post a new version if that is
>> preferred. 
> 
> I'll probably do that myself - the current code I have is a little
> different so the patch probably won't apply, anyway.  I'll need to
> munge it to suit the eventual struct xfs_eofblocks format, anyway.
> 

Ok, I'll have a v2 replacement of this once the alignment thing is fixed
up...

> 
>> @@ -136,7 +142,7 @@ prealloc_help(void)
>>  "\n"
...
>> -	prealloc_cmd.argmin = 1;
>> +	prealloc_cmd.argmin = 0;
> 
> While technically correct, it's not the desired behaviour.  I wanted
> it to issue the usage if you just type the comment. I think I need
> to add a "-a" flag for "flush all" here.
> 

Ok.

>> -	prealloc_cmd.oneline = _("Control specualtive preallocation");
>> +	prealloc_cmd.oneline = _("Control speculative preallocation");
> 
> Good catch, Brain! :)
> 

Today a typo, tomorrow the world! ;)

Brain

> Cheers,
> 
> Dave.
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs