Re: [PATCH] insane: detect and warn about relocations in .text

[Mark Hatle <mark.hatle@windriver.com>]

On 11/6/12 6:24 PM, Phil Blundell wrote:
> Ping?

I do think we need this.  Having the textrel does prevent prelinking as well.

--Mark

> On Wed, 2012-10-03 at 11:24 +0100, Phil Blundell wrote:
>> Signed-off-by: Phil Blundell <pb@pbcl.net>
>> ---
>> This requires qa.elf.run_objdump() so needs to be applied after the
>> patch which adds that function.
>>
>>   meta/classes/insane.bbclass |   26 +++++++++++++++++++++++++-
>>   1 file changed, 25 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
>> index 5848ab4..ff35ed8 100644
>> --- a/meta/classes/insane.bbclass
>> +++ b/meta/classes/insane.bbclass
>> @@ -108,7 +108,7 @@ def package_qa_get_machine_dict():
>>
>>
>>   # Currently not being used by default "desktop"
>> -WARN_QA ?= "ldflags useless-rpaths rpaths unsafe-references-in-binaries unsafe-references-in-scripts staticdev libdir"
>> +WARN_QA ?= "ldflags useless-rpaths rpaths unsafe-references-in-binaries unsafe-references-in-scripts staticdev libdir textrel"
>>   ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch la2 pkgconfig la perms dep-cmp"
>>
>>   ALL_QA = "${WARN_QA} ${ERROR_QA}"
>> @@ -421,6 +421,30 @@ def package_qa_check_desktop(path, name, d, elf, messages):
>>           for l in output:
>>               messages.append("Desktop file issue: " + l.strip())
>>
>> +QAPATHTEST[textrel] = "package_qa_textrel"
>> +def package_qa_textrel(path, name, d, elf, messages):
>> +    """
>> +    Check if the binary contains relocations in .text
>> +    """
>> +
>> +    if not elf:
>> +        return
>> +
>> +    if os.path.islink(path):
>> +        return
>> +
>> +    phdrs = elf.run_objdump("-p", d)
>> +    sane = True
>> +
>> +    import re
>> +    textrel_re = re.compile("\s+TEXTREL\s+")
>> +    for line in phdrs.split("\n"):
>> +        if textrel_re.match(line):
>> +	   sane = False
>> +
>> +    if not sane:
>> +        messages.append("ELF binary '%s' has relocations in .text" % path)
>> +
>>   QAPATHTEST[ldflags] = "package_qa_hash_style"
>>   def package_qa_hash_style(path, name, d, elf, messages):
>>       """
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>