From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: [PATCH 3/4] drm/ttm: remove ttm_bo_device->nice_mode Date: Wed, 07 Nov 2012 13:36:47 +0100 Message-ID: <509A55DF.4030809@vmware.com> References: <1352238594-14991-3-git-send-email-marcin.slusarz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-outbound-2.vmware.com (smtp-outbound-2.vmware.com [208.91.2.13]) by gabe.freedesktop.org (Postfix) with ESMTP id DE1D29E7EE for ; Wed, 7 Nov 2012 04:36:50 -0800 (PST) In-Reply-To: <1352238594-14991-3-git-send-email-marcin.slusarz@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Marcin Slusarz Cc: Thomas Hellstrom , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 11/06/2012 10:49 PM, Marcin Slusarz wrote: > It's unused. > > Signed-off-by: Marcin Slusarz > Cc: Thomas Hellstrom > --- > drivers/gpu/drm/ttm/ttm_bo.c | 1 - > include/drm/ttm/ttm_bo_driver.h | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > index 412486c..da7a985 100644 > --- a/drivers/gpu/drm/ttm/ttm_bo.c > +++ b/drivers/gpu/drm/ttm/ttm_bo.c > @@ -1570,7 +1570,6 @@ int ttm_bo_device_init(struct ttm_bo_device *bdev, > goto out_no_addr_mm; > > INIT_DELAYED_WORK(&bdev->wq, ttm_bo_delayed_workqueue); > - bdev->nice_mode = true; > INIT_LIST_HEAD(&bdev->ddestroy); > bdev->dev_mapping = NULL; > bdev->glob = glob; > diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h > index d803b92..95628e7 100644 > --- a/include/drm/ttm/ttm_bo_driver.h > +++ b/include/drm/ttm/ttm_bo_driver.h > @@ -521,8 +521,6 @@ struct ttm_bo_global { > * lru_lock: Spinlock that protects the buffer+device lru lists and > * ddestroy lists. > * @val_seq: Current validation sequence. > - * @nice_mode: Try nicely to wait for buffer idle when cleaning a manager. > - * If a GPU lockup has been detected, this is forced to 0. > * @dev_mapping: A pointer to the struct address_space representing the > * device address space. > * @wq: Work queue structure for the delayed delete workqueue. > @@ -556,7 +554,6 @@ struct ttm_bo_device { > * Protected by load / firstopen / lastclose /unload sync. > */ > > - bool nice_mode; > struct address_space *dev_mapping; > > /* Reviewed-by: Thomas Hellstrom