From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org,
swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] gpio: tegra: fix suspend/resume apis
Date: Wed, 07 Nov 2012 10:11:41 -0700 [thread overview]
Message-ID: <509A964D.2050205@wwwdotorg.org> (raw)
In-Reply-To: <1352300492-24779-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 11/07/2012 08:01 AM, Laxman Dewangan wrote:
> Following are changes done to fix the suspend/resume
> functionality of tegra gpio driver:
> - Protect suspend/resume callbacks with CONFIG_PM_SLEEP
> because CONFIG_PM doesn't actually enable any of the PM callbacks, it
> only allows to enable CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
> This means if CONFIG_PM is used to protect system sleep callbacks
> then it may end up unreferenced if only runtime PM is enabled.
>
> - Fix the suspend/resume APIs declaration as per callback prototype.
Seems plausible, so this patch,
Acked-by: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
I wonder why the suspend/resume functions weren't actually hooked up
anywhere before. Oh well.
Just one very minor nit below:
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> +#ifdef CONFIG_PM_SLEEP
> +static int tegra_gpio_resume(struct device *dev)
There are two spaces after "int" there.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linus.walleij@linaro.org, grant.likely@secretlab.ca,
swarren@nvidia.com, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/2] gpio: tegra: fix suspend/resume apis
Date: Wed, 07 Nov 2012 10:11:41 -0700 [thread overview]
Message-ID: <509A964D.2050205@wwwdotorg.org> (raw)
In-Reply-To: <1352300492-24779-2-git-send-email-ldewangan@nvidia.com>
On 11/07/2012 08:01 AM, Laxman Dewangan wrote:
> Following are changes done to fix the suspend/resume
> functionality of tegra gpio driver:
> - Protect suspend/resume callbacks with CONFIG_PM_SLEEP
> because CONFIG_PM doesn't actually enable any of the PM callbacks, it
> only allows to enable CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME.
> This means if CONFIG_PM is used to protect system sleep callbacks
> then it may end up unreferenced if only runtime PM is enabled.
>
> - Fix the suspend/resume APIs declaration as per callback prototype.
Seems plausible, so this patch,
Acked-by: Stephen Warren <swarren@nvidia.com>
I wonder why the suspend/resume functions weren't actually hooked up
anywhere before. Oh well.
Just one very minor nit below:
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> +#ifdef CONFIG_PM_SLEEP
> +static int tegra_gpio_resume(struct device *dev)
There are two spaces after "int" there.
next prev parent reply other threads:[~2012-11-07 17:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 15:01 [PATCH 1/2] gpio: tegra: create irq mapping in gpio_to_irq Laxman Dewangan
2012-11-07 15:01 ` Laxman Dewangan
2012-11-07 15:01 ` [PATCH 2/2] gpio: tegra: fix suspend/resume apis Laxman Dewangan
2012-11-07 15:01 ` Laxman Dewangan
[not found] ` <1352300492-24779-2-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-07 17:11 ` Stephen Warren [this message]
2012-11-07 17:11 ` Stephen Warren
2012-11-08 21:24 ` Linus Walleij
2012-11-08 21:24 ` Linus Walleij
[not found] ` <1352300492-24779-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-11-07 17:08 ` [PATCH 1/2] gpio: tegra: create irq mapping in gpio_to_irq Stephen Warren
2012-11-07 17:08 ` Stephen Warren
2012-11-08 4:29 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509A964D.2050205@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.