From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH] ARM: EXYNOS: Make s3c_device_i2c0 always use id 0 Date: Wed, 07 Nov 2012 19:02:36 +0100 Message-ID: <509AA23C.6000704@gmail.com> References: <4039915.8GOx0SKq2B@amdc1227> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:45769 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162Ab2KGSCq (ORCPT ); Wed, 7 Nov 2012 13:02:46 -0500 Received: by mail-bk0-f46.google.com with SMTP id jk13so853847bkc.19 for ; Wed, 07 Nov 2012 10:02:45 -0800 (PST) In-Reply-To: <4039915.8GOx0SKq2B@amdc1227> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Tomasz Figa Cc: linux-samsung-soc , jhkim@insignal.co.kr, linux-arm-kernel , Kukjin Kim , Kyungmin Park , Marek Szyprowski On 11/07/2012 02:00 PM, Tomasz Figa wrote: > This patch removes compatibility definitions added long time ago when > clock ids were used instead of devnames that were needed for platforms > with only one i2c controller with id -1 (some s3c24xx's). > > Because currently devname field is used for matching device instances to > clocks and if no devname is provided (as in clock-s3c2412.c and > common-s3c2443.c for i2c clock, both in arch/arm/mach-s3c24xx) the clock > is being matched only by name, so s3c_device_i2c0 can always have id 0. > > This patch solves the issue with i2c0 broken on boards where its the > only i2c controller used, tested on Origen. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park Reviewed-by: Sylwester Nawrocki -- Thanks, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 From: sylvester.nawrocki@gmail.com (Sylwester Nawrocki) Date: Wed, 07 Nov 2012 19:02:36 +0100 Subject: [PATCH] ARM: EXYNOS: Make s3c_device_i2c0 always use id 0 In-Reply-To: <4039915.8GOx0SKq2B@amdc1227> References: <4039915.8GOx0SKq2B@amdc1227> Message-ID: <509AA23C.6000704@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/07/2012 02:00 PM, Tomasz Figa wrote: > This patch removes compatibility definitions added long time ago when > clock ids were used instead of devnames that were needed for platforms > with only one i2c controller with id -1 (some s3c24xx's). > > Because currently devname field is used for matching device instances to > clocks and if no devname is provided (as in clock-s3c2412.c and > common-s3c2443.c for i2c clock, both in arch/arm/mach-s3c24xx) the clock > is being matched only by name, so s3c_device_i2c0 can always have id 0. > > This patch solves the issue with i2c0 broken on boards where its the > only i2c controller used, tested on Origen. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park Reviewed-by: Sylwester Nawrocki -- Thanks, Sylwester