From: Stephen Warren <swarren@wwwdotorg.org>
To: AnilKumar Ch <anilkumar@ti.com>
Cc: dmitry.torokhov@gmail.com, grant.likely@secretlab.ca,
devicetree-discuss@lists.ozlabs.org, dgdunix@gmail.com,
rob.herring@calxeda.com, linux-input@vger.kernel.org
Subject: Re: [PATCH v4] Input: matrix-keypad - Add device tree support
Date: Thu, 08 Nov 2012 09:55:33 -0700 [thread overview]
Message-ID: <509BE405.60204@wwwdotorg.org> (raw)
In-Reply-To: <1352280725-452-1-git-send-email-anilkumar@ti.com>
On 11/07/2012 02:32 AM, AnilKumar Ch wrote:
> Add device tree support to matrix keypad driver and usage details
> are added to device tree documentation. Driver was tested on AM335x
> EVM.
> diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
> +Optional Properties:
> +- clustered-irq: have clustered irq number, that is needed if the irq
> + is a combined irq source for the whole matrix keypad.
> + This is useful if rows and columns of the keypad are
> + connected to a GPIO expander.
> +- clustered-irq-flags: clustered irq flags to specify the interrupt line
> + behaviour among IRQF_TRIGGER_*
I still don't understand why there's a need for a clustered-irq-flags
property; if those flags are the flags for an interrupt, why aren't the
flags part of the clustered-irq interrupt specifier, just like any other
interrupt in DT?
next prev parent reply other threads:[~2012-11-08 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 9:32 [PATCH v4] Input: matrix-keypad - Add device tree support AnilKumar Ch
2012-11-07 9:38 ` AnilKumar, Chimata
2012-11-07 16:57 ` Stephen Warren
2012-11-08 5:23 ` AnilKumar, Chimata
2012-11-08 16:55 ` Stephen Warren [this message]
2012-11-09 11:07 ` AnilKumar, Chimata
2012-11-09 17:19 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509BE405.60204@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=anilkumar@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dgdunix@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-input@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.