From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:64478 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702Ab2KHTDs (ORCPT ); Thu, 8 Nov 2012 14:03:48 -0500 Received: by mail-bk0-f46.google.com with SMTP id jk13so1358429bkc.19 for ; Thu, 08 Nov 2012 11:03:46 -0800 (PST) Message-ID: <509BF403.2080002@googlemail.com> Date: Thu, 08 Nov 2012 20:03:47 +0200 From: =?UTF-8?B?RnJhbmsgU2Now6RmZXI=?= MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org Subject: Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers References: <1350838349-14763-1-git-send-email-fschaefer.oss@googlemail.com> <20121028175752.447c39d5@redhat.com> <508EA1B8.3070304@googlemail.com> <20121029180348.7e7967aa@redhat.com> <508EF1CF.8090602@googlemail.com> <20121030010012.30e1d2de@redhat.com> <20121030020619.6e854f70@redhat.com> <50900BF6.1030502@googlemail.com> In-Reply-To: <50900BF6.1030502@googlemail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: Am 30.10.2012 19:18, schrieb Frank Schäfer: > Am 30.10.2012 06:06, schrieb Mauro Carvalho Chehab: > > >> Did a git bisect. The last patch where the bug doesn't occur is this >> changeset: >> em28xx: add module parameter for selection of the preferred USB transfer type >> >> That means that this changeset broke it: >> >> em28xx: use common urb data copying function for vbi and non-vbi devices > Ok, thanks. > That means we are VERY close... > > I think this is the only change that could cause the trouble: >> @@ -599,6 +491,7 @@ static inline int em28xx_urb_data_copy_vbi(struct em28xx *dev, struct urb *urb) >> len = actual_length - 4; >> } else if (p[0] == 0x22 && p[1] == 0x5a) { >> /* start video */ >> + dev->capture_type = 1; >> p += 4; >> len = actual_length - 4; >> } else { > Could you try again with this line commented out ? (em28xx-video.c, line > 494 in the patched file). > usb_debug=1 would be usefull, too. > >> I didn't test them with my Silvercrest webcam yet. > I re-tested 5 minutes ago with this device and it works fine. > Btw, which frame rates do you get ? ;) > > Regards, > Frank Today I had the chance to test these patches with a Hauppauge HVR-930c. Couldn't test analog TV (not supported yet), but DVB works fine, too. So patches 1 to 21 have been tested now and do at least not cause any regressions. I would like to drop the last two patches (22+23) of this series, because - they are actually not related to USB bulk transfers - patch 22 needs to be fixed for analog+vbi (will get an analog device for testing next week) - I'm working on further improvements/changes in this area (including em25xx support) So I will better come up with a separate patch series later. Will send a v2 of this patch series soon. Regards, Frank