All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] video: atmel: implement lcd_setcolreg funtion
Date: Fri, 09 Nov 2012 11:46:32 +0800	[thread overview]
Message-ID: <509C7C98.90904@atmel.com> (raw)
In-Reply-To: <201211081408.34347.marex@denx.de>

Hi Marek Vasut,

On 11/8/2012 21:08, Marek Vasut wrote:
> Dear Bo Shen,
>
> [...]
>> +/*
>> + * the CLUT register map as following
>> + * RCLUT(24 ~ 16), GCLUT(15 ~ 8), BCLUT(7 ~ 0)
>> + */
>> +void lcd_setcolreg(ushort regno, ushort red, ushort green, ushort blue)
>> +{
>> +	lcdc_writel((red << 16) & 0xff0000 | (green << 8) & 0xff00 |
>> +		blue & 0xff, panel_info.mmio + ATMEL_LCDC_LUT(regno));
>> +}
>> +
>
> Why don't you #define these values instead?

Ok, I will change to use #define.

Thanks,

Best Regards,
Bo Shen

  reply	other threads:[~2012-11-09  3:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02 14:18 [U-Boot] [PATCH v2] common/lcd: use lcd_setcolreg() to setup CLUT Andreas Bießmann
2012-11-06 10:13 ` [U-Boot] [PATCH v3 0/2] rework common/lcd Andreas Bießmann
2012-11-06 10:13   ` [U-Boot] [PATCH v3 1/2] video: atmel: implement lcd_setcolreg funtion Andreas Bießmann
2012-11-06 22:54     ` Marek Vasut
2012-11-07  1:26       ` Bo Shen
2012-11-07 13:26         ` Marek Vasut
2012-11-08  3:06           ` Bo Shen
2012-11-08  7:53             ` Andreas Bießmann
2012-11-08  9:10     ` [U-Boot] [PATCH v4] " Bo Shen
2012-11-08 13:08       ` Marek Vasut
2012-11-09  3:46         ` Bo Shen [this message]
2012-11-09  3:49     ` [U-Boot] [Patch v5] video: atmel: implement lcd_setcolreg function Bo Shen
2012-11-10 13:13       ` Anatolij Gustschin
2012-11-06 10:13   ` [U-Boot] [PATCH v3 2/2] common/lcd: use lcd_setcolreg() to setup CLUT Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509C7C98.90904@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.