[PATCH] libxl: fix reboot failure of migrated domain

[PATCH] libxl: fix reboot failure of migrated domain

[Kouya Shimura]

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

The same problem was once fixed by c/s 23878:59c7213b5949
but c/s 25344:0f3b1e13d6af broke it.

Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>


[-- Attachment #2: fix_reboot.patch --]
[-- Type: text/x-patch, Size: 525 bytes --]

diff -r 62885b3c34c8 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Thu Nov 08 17:58:19 2012 +0100
+++ b/tools/libxl/xl_cmdimpl.c	Fri Nov 09 16:11:04 2012 +0900
@@ -1927,7 +1927,7 @@ start:
          * On subsequent reboot etc we should create the domain, not
          * restore/migrate-receive it again.
          */
-        restore_file = NULL;
+        restoring = 0;
     }else{
         ret = libxl_domain_create_new(ctx, &d_config, &domid,
                                       0, autoconnect_console_how);

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] libxl: fix reboot failure of migrated domain

[Ian Campbell]

On Fri, 2012-11-09 at 07:51 +0000, Kouya Shimura wrote:
> The same problem was once fixed by c/s 23878:59c7213b5949
> but c/s 25344:0f3b1e13d6af broke it.
> 
> Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

and applied.

Ian (J): Not sure if the test harness does much after the migration
phase but adding a few lifecycle ops as a sanity check might be useful?

Ian.

Re: [PATCH] libxl: fix reboot failure of migrated domain

[Ian Jackson]

Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: fix reboot failure of migrated domain"):
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> and applied.
> 
> Ian (J): Not sure if the test harness does much after the migration
> phase but adding a few lifecycle ops as a sanity check might be useful?

At least a reboot would probably be a good idea.  I need to merge my
two branches before I can make a change like that, though.

Ian.