From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36489)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1TWkSI-000362-9G
	for qemu-devel@nongnu.org; Fri, 09 Nov 2012 04:00:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1TWkS6-0007t7-Tr
	for qemu-devel@nongnu.org; Fri, 09 Nov 2012 04:00:50 -0500
Received: from isrv.corpit.ru ([86.62.121.231]:42967)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1TWkS6-0007ro-Md
	for qemu-devel@nongnu.org; Fri, 09 Nov 2012 04:00:38 -0500
Message-ID: <509CC62A.7060905@msgid.tls.msk.ru>
Date: Fri, 09 Nov 2012 13:00:26 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <alpine.LFD.2.02.1211012105080.690@bbs.intern>
	<CAFEAcA_WYtoocPVMk1eHSXNoMK-1WLP7+SsiYcMoSRtOJK3rwA@mail.gmail.com>
	<509C1F16.2090808@redhat.com>
	<alpine.GSO.2.00.1211090054080.11771@mono>
In-Reply-To: <alpine.GSO.2.00.1211090054080.11771@mono>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: BALATON Zoltan <balaton@eik.bme.hu>
Cc: Marek Vasut <marex@denx.de>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Gerhard Wiesinger <lists@wiesinger.com>, "Serge E. Hallyn" <serge@hallyn.com>

On 09.11.2012 03:55, BALATON Zoltan wrote:
> On Thu, 8 Nov 2012, Gerd Hoffmann wrote:
>>> I think this is fixing this at the wrong level. Either we
>>> should require that drivers (in this case vmware_vga.c)
>>> must not call dpy_gfx_update() with out of range values,
>>> or we should do the clipping in the console.c layer, but
>>> I don't think requiring every UI backend to clip is the
>>> right thing. Anthony?
>>
>> Agree.  IMHO vmware_vga.c is at fault here and should be fixed.  We can
>> add some asserts to console.[ch] to enforce this ...
> 
> Would the attached patch help?

I fixed this 2 times, and I remember two other people fixing
the same thing too already.  Lemme find some refs...

thread.gmane.org/gmane.comp.emulators.qemu/166064

---
Is it the same as https://bugs.launchpad.net/bugs/918791 ?
At least it appears to be the same theme...  But there,
the patch (https://launchpadlibrarian.net/94916786/qemu-vmware.debdiff)
also updates width/height.  My comment:
https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/918791/comments/21
---

Adding some Cc's....