From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWkXl-0006k3-8a for qemu-devel@nongnu.org; Fri, 09 Nov 2012 04:06:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TWkXf-0001H7-Dh for qemu-devel@nongnu.org; Fri, 09 Nov 2012 04:06:29 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:54330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWkXf-0001Gt-5s for qemu-devel@nongnu.org; Fri, 09 Nov 2012 04:06:23 -0500 Message-ID: <509CC78D.6040404@msgid.tls.msk.ru> Date: Fri, 09 Nov 2012 13:06:21 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <509C1F16.2090808@redhat.com> <509CC62A.7060905@msgid.tls.msk.ru> In-Reply-To: <509CC62A.7060905@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan Cc: Marek Vasut , Peter Maydell , Anthony Liguori , qemu-devel@nongnu.org, Gerd Hoffmann , Gerhard Wiesinger , "Serge E. Hallyn" On 09.11.2012 13:00, Michael Tokarev wrote: > On 09.11.2012 03:55, BALATON Zoltan wrote: >> On Thu, 8 Nov 2012, Gerd Hoffmann wrote: >>>> I think this is fixing this at the wrong level. Either we >>>> should require that drivers (in this case vmware_vga.c) >>>> must not call dpy_gfx_update() with out of range values, >>>> or we should do the clipping in the console.c layer, but >>>> I don't think requiring every UI backend to clip is the >>>> right thing. Anthony? >>> >>> Agree. IMHO vmware_vga.c is at fault here and should be fixed. We can >>> add some asserts to console.[ch] to enforce this ... >> >> Would the attached patch help? > > I fixed this 2 times, and I remember two other people fixing > the same thing too already. Lemme find some refs... > > http://thread.gmane.org/gmane.comp.emulators.qemu/166064 > > --- > Is it the same as https://bugs.launchpad.net/bugs/918791 ? > At least it appears to be the same theme... But there, > the patch (https://launchpadlibrarian.net/94916786/qemu-vmware.debdiff) > also updates width/height. My comment: > https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/918791/comments/21 > --- Another reference: the same problem in qxl (Gerd should know this area): http://thread.gmane.org/gmane.comp.emulators.qemu/171093 this patch is a cleanup, -- the problem has been fixed twice in a row in qxl. We've 3 fixes for it in vmware now too. So figuring out the proper level where to fix it is important... /mjt