From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH] ARM: S3C64XX: Statically define parent clock of the "camera" clock Date: Fri, 09 Nov 2012 11:05:40 +0100 Message-ID: <509CD574.2050909@gmail.com> References: <1352449929-20168-1-git-send-email-sylvester.nawrocki@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:32858 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976Ab2KIKFp (ORCPT ); Fri, 9 Nov 2012 05:05:45 -0500 Received: by mail-bk0-f46.google.com with SMTP id jk13so1543038bkc.19 for ; Fri, 09 Nov 2012 02:05:44 -0800 (PST) In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Andrey Gusakov Cc: kgene.kim@samsung.com, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Hi, On 11/09/2012 10:31 AM, Andrey Gusakov wrote: > On Fri, Nov 9, 2012 at 12:32 PM, Sylwester Nawrocki > wrote: >> The "camera" clock defined in arch/arm/mach-s3c64xx/clock.c has null >> clock source mux control register as it can have only one parent >> clock. In such cases there is a need to configure the parent clock >> statically, otherwise s3c_set_clksrc() bails out with an error message >> "no parent clock specified" leaving the parent clock not configured. >> Define statically the parent clock so it is possible to get or set >> rate of the "camera" clock. >> While at it remove the unneded null reg_src definition. >> >> Reported-by: In-Bae Jeong >> Signed-off-by: Sylwester Nawrocki >> --- >> arch/arm/mach-s3c64xx/clock.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c64xx/clock.c >> index 28041e8..2e6d7f9 100644 >> --- a/arch/arm/mach-s3c64xx/clock.c >> +++ b/arch/arm/mach-s3c64xx/clock.c >> @@ -744,9 +744,9 @@ static struct clksrc_clk clksrcs[] = { >> .name = "camera", >> .ctrlbit = S3C_CLKCON_SCLK_CAM, >> .enable = s3c64xx_sclk_ctrl, >> + .parent =&clk_h2, >> }, >> .reg_div = { .reg = S3C_CLK_DIV0, .shift = 20, .size = 4 }, >> - .reg_src = { .reg = NULL, .shift = 0, .size = 0 }, >> .sources =&clkset_camif, > Just figure out that .sources can be removed to. And seems > "clkset_camif" and "clkset_camif_list" can be removed as unused. OK, you're right. I think it could be done as a separate patch, depending on this one to avoid conflicts. > I'll try to test it tiday. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: sylvester.nawrocki@gmail.com (Sylwester Nawrocki) Date: Fri, 09 Nov 2012 11:05:40 +0100 Subject: [PATCH] ARM: S3C64XX: Statically define parent clock of the "camera" clock In-Reply-To: References: <1352449929-20168-1-git-send-email-sylvester.nawrocki@gmail.com> Message-ID: <509CD574.2050909@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 11/09/2012 10:31 AM, Andrey Gusakov wrote: > On Fri, Nov 9, 2012 at 12:32 PM, Sylwester Nawrocki > wrote: >> The "camera" clock defined in arch/arm/mach-s3c64xx/clock.c has null >> clock source mux control register as it can have only one parent >> clock. In such cases there is a need to configure the parent clock >> statically, otherwise s3c_set_clksrc() bails out with an error message >> "no parent clock specified" leaving the parent clock not configured. >> Define statically the parent clock so it is possible to get or set >> rate of the "camera" clock. >> While at it remove the unneded null reg_src definition. >> >> Reported-by: In-Bae Jeong >> Signed-off-by: Sylwester Nawrocki >> --- >> arch/arm/mach-s3c64xx/clock.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/arch/arm/mach-s3c64xx/clock.c b/arch/arm/mach-s3c64xx/clock.c >> index 28041e8..2e6d7f9 100644 >> --- a/arch/arm/mach-s3c64xx/clock.c >> +++ b/arch/arm/mach-s3c64xx/clock.c >> @@ -744,9 +744,9 @@ static struct clksrc_clk clksrcs[] = { >> .name = "camera", >> .ctrlbit = S3C_CLKCON_SCLK_CAM, >> .enable = s3c64xx_sclk_ctrl, >> + .parent =&clk_h2, >> }, >> .reg_div = { .reg = S3C_CLK_DIV0, .shift = 20, .size = 4 }, >> - .reg_src = { .reg = NULL, .shift = 0, .size = 0 }, >> .sources =&clkset_camif, > Just figure out that .sources can be removed to. And seems > "clkset_camif" and "clkset_camif_list" can be removed as unused. OK, you're right. I think it could be done as a separate patch, depending on this one to avoid conflicts. > I'll try to test it tiday. Thanks.