All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [GIT PULL] drbd-8.4.2 for the linux-3.8 merge window
Date: Fri, 09 Nov 2012 13:56:16 +0100	[thread overview]
Message-ID: <509CFD70.5020807@kernel.dk> (raw)
In-Reply-To: <4229483.8Hqs9YQUgX@fat-tyre>

On 2012-11-09 13:42, Philipp Reisner wrote:
> [...]
>>> It has the sysfs bits in again. The reason for that is that we want to
>>> expose more information by that, and remove the /proc/drbd with the
>>> next evolutionary step. -- In case this is a show stopper, let me
>>> remove the sysfs bits.
>>
>> The exact same sysfs bits I complained about last time? If yes, then I
>> don't understand why you haven't changed yet. Or why you are trying to
>> push the same bits again that got rejected last time.
>>
> 
> I had the impression it was rejected because I submitted the pull request
> too late to you. In the sense of, it might go in, if it gets submitted
> for inclusion before the merge window opens...
> Apparently my impression was wrong. You will get an updated pull-request 
> with the sysfs bits removed

It was late, but that was a different issue. I just re-read the Oct 3rd
emails on this, and I definitely did recommend that you looked at
debugfs or similar for this. We're not putting another top-queue level
directory in for a block device that is specific to drbd.

-- 
Jens Axboe


WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] drbd-8.4.2 for the linux-3.8 merge window
Date: Fri, 09 Nov 2012 13:56:16 +0100	[thread overview]
Message-ID: <509CFD70.5020807@kernel.dk> (raw)
In-Reply-To: <4229483.8Hqs9YQUgX@fat-tyre>

On 2012-11-09 13:42, Philipp Reisner wrote:
> [...]
>>> It has the sysfs bits in again. The reason for that is that we want to
>>> expose more information by that, and remove the /proc/drbd with the
>>> next evolutionary step. -- In case this is a show stopper, let me
>>> remove the sysfs bits.
>>
>> The exact same sysfs bits I complained about last time? If yes, then I
>> don't understand why you haven't changed yet. Or why you are trying to
>> push the same bits again that got rejected last time.
>>
> 
> I had the impression it was rejected because I submitted the pull request
> too late to you. In the sense of, it might go in, if it gets submitted
> for inclusion before the merge window opens...
> Apparently my impression was wrong. You will get an updated pull-request 
> with the sysfs bits removed

It was late, but that was a different issue. I just re-read the Oct 3rd
emails on this, and I definitely did recommend that you looked at
debugfs or similar for this. We're not putting another top-queue level
directory in for a block device that is specific to drbd.

-- 
Jens Axboe


  reply	other threads:[~2012-11-09 12:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 11:36 [Drbd-dev] [GIT PULL] drbd-8.4.2 for the linux-3.8 merge window Philipp Reisner
2012-11-09 11:36 ` Philipp Reisner
2012-11-09 11:40 ` [Drbd-dev] " Jens Axboe
2012-11-09 11:40   ` Jens Axboe
2012-11-09 12:42   ` [Drbd-dev] " Philipp Reisner
2012-11-09 12:42     ` Philipp Reisner
2012-11-09 12:56     ` Jens Axboe [this message]
2012-11-09 12:56       ` Jens Axboe
2012-11-09 13:33       ` [Drbd-dev] " Philipp Reisner
2012-11-09 13:33         ` Philipp Reisner
2012-11-09 14:18         ` [Drbd-dev] " Jens Axboe
2012-11-09 14:18           ` Jens Axboe
2012-11-09 14:50           ` [Drbd-dev] " Jens Axboe
2012-11-09 14:50             ` Jens Axboe
2012-11-09 15:19             ` [Drbd-dev] " Philipp Reisner
2012-11-09 15:19               ` Philipp Reisner
2012-11-09 19:49               ` [Drbd-dev] " Jens Axboe
2012-11-09 19:49                 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509CFD70.5020807@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=drbd-dev@lists.linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.reisner@linbit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.