Re: [Devel] ref-counting races?

[Andriy Gapon <avg at FreeBSD.org>]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

on 09/11/2012 17:42 Moore, Robert said the following:
>> To make sure that we speak about the same thing - is e.g.
>> AcpiUtEvaluateObject always called under that lock?
> 
> Yes.
> 
> 
> AcpiUtEvaluateObject
>     AcpiNsEvaluate
>         AcpiExEnterInterpreter ();
>             AcpiUtAcquireMutex (ACPI_MTX_INTERPRETER);
>         AcpiPsExecuteMethod (Info);
> 

This is not exactly what I meant.  ACPI_MTX_INTERPRETER does not cover the calls
to AcpiUtRemoveReference that can be made in AcpiUtEvaluateObject or in
AcpiUtExecute_HID or in AcpiUtEvaluateNumericObject, etc.
There could be other places in the code where AcpiUtRemoveReference or
AcpiUtAddReference are called without any lock serializing the access to a
reference counter.

-- 
Andriy Gapon