From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60246)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TWsGl-0008Aj-CI
	for qemu-devel@nongnu.org; Fri, 09 Nov 2012 12:21:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TWsGh-0001Zj-D1
	for qemu-devel@nongnu.org; Fri, 09 Nov 2012 12:21:27 -0500
Message-ID: <509D3B8B.8050900@suse.de>
Date: Fri, 09 Nov 2012 18:21:15 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20120513160331.5b774c93.yizhouzhou@ict.ac.cn>
	<4FB0F89F.6080306@redhat.com> <4FD74513.2000500@suse.de>
	<4FD747BF.3020809@redhat.com> <50783CCA.902@suse.de>
	<507BD3D1.3010804@redhat.com>
In-Reply-To: <507BD3D1.3010804@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] fixing qemu-0.1X endless loop in
	qcow2_alloc_cluster_offset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Zhouyi Zhou <yizhouzhou@ict.ac.cn>, Bruce Rogers <brogers@suse.com>, Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org, qemu-stable@nongnu.org

Am 15.10.2012 11:13, schrieb Kevin Wolf:
> What I'm suggesting (not even compile tested!) is:
>=20
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>=20
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 48e1b95..d665675 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -388,10 +388,7 @@ typedef struct QCowAIOCB {
>=20
>  static void qcow2_aio_cancel(BlockDriverAIOCB *blockacb)
>  {
> -    QCowAIOCB *acb =3D container_of(blockacb, QCowAIOCB, common);
> -    if (acb->hd_aiocb)
> -        bdrv_aio_cancel(acb->hd_aiocb);
> -    qemu_aio_release(acb);
> +    qemu_aio_flush();
>  }
>=20
>  static AIOPool qcow2_aio_pool =3D {

Thanks, we've applied this to stable-0.15.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg