Re: [OE-core] [PATCH] librsvg: update 2.58.2 -> 2.59.2

[Ross Burton <Ross.Burton@arm.com>]

On 4 Dec 2024, at 12:08, Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote:
> +export EXTRA_NATIVE_PKGCONFIG_PATH = "${B}/meson-uninstalled:"
> +LDFLAGS += " -L${B}/rsvg"
> +# needed on ubuntu 20.04/debian 11 to avoid 'undefined reference to `dlsym'' errors
> +BUILD_LDFLAGS += " -ldl"

That’s a big pile of yuck, some of which feels like “how does this work upstream?” levels of breakage.  Are we exposing flaws in the librsvg build, or our meson integration, or something else?

> +SYSROOT_PREPROCESS_FUNCS:append:class-target = " pkgconfig_sysroot_preprocess"
> +
> +# installed .pc file contains
> +# prefix=${pcfiledir}/../..
> +# which is expanded to an absolute path, and thus doesn't work when additionally prefixed with a sysroot directory
> +pkgconfig_sysroot_preprocess() {
> +        sed -i -e "s:^prefix=.*:prefix=${prefix}:g" ${SYSROOT_DESTDIR}${libdir}/pkgconfig/librsvg-2.0.pc
> +}

Surely a better fix is to upstream a change to set the prefix to the prefix?

Ross