From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerhard Wiesinger <lists@wiesinger.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION
Date: Sat, 10 Nov 2012 09:55:49 +0100 [thread overview]
Message-ID: <509E1695.20705@redhat.com> (raw)
In-Reply-To: <509E10AD.2030602@wiesinger.com>
Il 10/11/2012 09:30, Gerhard Wiesinger ha scritto:
>>> 2.) Added debug code to block.c and to block/vmdk.c to verify
>>> correctness
>> Same here. Also, please use the tracing infrastructure---a lot of the
>> debug
>> messages you're adding, though not all, are in fact already available
>> (not
>> saying the others aren't useful!)
>
> Any chance that the patch with debug code only (after some cleaning)
> would be accepted (other modules do debug logging, too)?
> I don't like to do useless work.
> Tracing infrastructure is quite limited to function calls only (as far
> as I saw).
No, tracing infrastructure uses function calls for tracing (messages go
into trace-events) but you can apply it to everything you want. Use the
stderr backend to debug it.
Debug patches using traces are certainly welcome.
Paolo
next prev parent reply other threads:[~2012-11-10 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 19:05 [Qemu-devel] [PATCH] block.c, block/vmdk.c: Fixed major bug in VMDK WRITE and READ handling - FIXES DATA CORRUPTION Gerhard Wiesinger
2012-11-09 5:12 ` Fam Zheng
2012-11-09 6:51 ` Gerhard Wiesinger
2012-11-09 7:38 ` Lei Li
2012-11-09 8:26 ` Paolo Bonzini
2012-11-10 8:30 ` Gerhard Wiesinger
2012-11-10 8:55 ` Paolo Bonzini [this message]
2012-11-10 9:59 ` Gerhard Wiesinger
2012-11-13 12:27 ` Kevin Wolf
2012-11-13 13:36 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509E1695.20705@redhat.com \
--to=pbonzini@redhat.com \
--cc=lists@wiesinger.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.