All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: Re: [patch,v3 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node
Date: Sat, 10 Nov 2012 09:59:55 +0100	[thread overview]
Message-ID: <509E178B.6090601@acm.org> (raw)
In-Reply-To: <1352488687-19935-5-git-send-email-jmoyer@redhat.com>

On 11/09/12 20:18, Jeff Moyer wrote:
> -	cmd = kmem_cache_zalloc(pool->cmd_slab, gfp_mask | pool->gfp_mask);
> +	cmd = kmem_cache_alloc_node(pool->cmd_slab,
> +				    gfp_mask | pool->gfp_mask | __GFP_ZERO,
> +				    node);

Hello Jeff,

Is it necessary to add __GFP_ZERO here ? And if so, why ?

Thanks,

Bart.

  reply	other threads:[~2012-11-10  8:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 19:17 [patch,v3 00/10] make I/O path allocations more numa-friendly Jeff Moyer
2012-11-09 19:17 ` [patch,v3 01/10] scsi: add scsi_host_alloc_node Jeff Moyer
2012-11-09 19:17 ` [patch,v3 02/10] scsi: make __scsi_alloc_queue numa-aware Jeff Moyer
2012-11-09 19:18 ` [patch,v3 03/10] scsi: make scsi_alloc_sdev numa-aware Jeff Moyer
2012-11-09 19:18 ` [patch,v3 04/10] scsi: allocate scsi_cmnd-s from the device's local numa node Jeff Moyer
2012-11-10  8:59   ` Bart Van Assche [this message]
2012-11-12 14:25     ` Jeff Moyer
2012-11-09 19:18 ` [patch,v3 05/10] sd: use alloc_disk_node Jeff Moyer
2012-11-09 19:18 ` [patch,v3 06/10] ata: use scsi_host_alloc_node Jeff Moyer
2012-11-16  4:33   ` Jeff Garzik
2012-11-09 19:18 ` [patch,v3 07/10] megaraid_sas: " Jeff Moyer
2012-11-09 19:18 ` [patch,v3 08/10] mpt2sas: " Jeff Moyer
2012-11-09 19:18 ` [patch,v3 09/10] lpfc: " Jeff Moyer
2012-11-09 19:18 ` [patch,v3 10/10] cciss: use blk_init_queue_node Jeff Moyer
2012-11-16  8:08 ` [patch,v3 00/10] make I/O path allocations more numa-friendly Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509E178B.6090601@acm.org \
    --to=bvanassche@acm.org \
    --cc=JBottomley@parallels.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.