From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D675C4345F for ; Sat, 27 Apr 2024 05:58:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0867510FEDC; Sat, 27 Apr 2024 05:58:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="cF2sR36W"; dkim-atps=neutral Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by gabe.freedesktop.org (Postfix) with ESMTPS id 04EEF10FEDC for ; Sat, 27 Apr 2024 05:58:25 +0000 (UTC) Message-ID: <509b3822-dcf6-45eb-9516-ba8ff2cc4382@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714197503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pxlklMfBDzUJzfzH3D9A2wRzbh/nwoFGA5lYNX7H0P0=; b=cF2sR36WA5QZw0FBHgOJ0ruxDsHJ0SIZ69AjdZ6LFB6lwTkj0I/zcr1BZkalt9X24iVj+F 7xmzjBDQEO8LWg8qk0SR2+hi5FwxcmozZdUCfFwieX+ywOFT3waCBsHeUcJpfDoh/pUlsK fBl47oVHcIW+Lyn3IMvWt/VrKHXSFMw= Date: Sat, 27 Apr 2024 13:57:46 +0800 MIME-Version: 1.0 Subject: Re: [v1,1/3] drm/panel: ili9341: Correct use of device property APIs To: Maxime Ripard Cc: Andy Shevchenko , Neil Armstrong , Randy Dunlap , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter References: <20240425142706.2440113-2-andriy.shevchenko@linux.intel.com> <2599705c-0a64-4742-b1d7-330e9fde6e7a@linux.dev> <20240426-married-augmented-mantis-ff7edd@penduick> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <20240426-married-augmented-mantis-ff7edd@penduick> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 2024/4/26 14:23, Maxime Ripard wrote: > Hi, > > On Fri, Apr 26, 2024 at 04:43:18AM +0800, Sui Jingfeng wrote: >> On 2024/4/26 03:10, Andy Shevchenko wrote: >>> On Fri, Apr 26, 2024 at 02:08:16AM +0800, Sui Jingfeng wrote: >>>> On 2024/4/25 22:26, Andy Shevchenko wrote: >>>>> It seems driver missed the point of proper use of device property APIs. >>>>> Correct this by updating headers and calls respectively. >>>> You are using the 'seems' here exactly saying that you are not 100% sure. >>>> >>>> Please allow me to tell you the truth: This patch again has ZERO effect. >>>> It fix nothing. And this patch is has the risks to be wrong. >>> Huh?! Really, stop commenting the stuff you do not understand. >> I'm actually a professional display drivers developer at the downstream >> in the past, despite my contribution to upstream is less. But I believe >> that all panel driver developers know what I'm talking about. So please >> have take a look at my replies. > Most of the interactions you had in this series has been uncalled for. > You might be against a patch, but there's no need to go to such length. > > As far as I'm concerned, this patch is fine to me in itself, and I don't > see anything that would prevent us from merging it. No one is preventing you, as long as don't misunderstanding what other people's technical replies intentionally. I'm just a usual and normal contributor, I hope the world will better than yesterday. Saying such thing to me may not proper, I guess you may want to talk to peoples who has the push rights, just make sure it isn't a insult to the professionalism of drm bridge community itself though. We still grateful for you help and admire you numerous contribution, thanks. -- Best regards, Sui