Re: [PATCH v6 4/6] wifi: rtlwifi: Move code from rtl8192de to rtl8192d-common

[Bitterblue Smith <rtl8821cerfe2@gmail.com>]

On 22/04/2024 05:55, Ping-Ke Shih wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>> Create the new module rtl8192d-common and move some code into it from
>> rtl8192de. Now the rtl8192de driver (PCI) and the new rtl8192du driver
>> (USB) can share some of the code.
>>
>> This is mostly the code that required little effort to make it
>> shareable. There are a few more functions which they could share, with
>> more changes.
>>
>> Add phy_iq_calibrate member to struct rtl_hal_ops to allow moving the
>> TX power tracking code from dm.c.
>>
>> The other changes in this patch are adjusting whitespace, renaming some
>> functions, making some arrays const, and making checkpatch.pl less
>> unhappy.
>>
>> rtl8192de is compile-tested only. rtl8192d-common is tested with the
>> new rtl8192du driver.
>>
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> 
> [..]
> 
>> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192d/main.c
>> @@ -0,0 +1,9 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/* Copyright(c) 2009-2012  Realtek Corporation.*/
>> +
>> +#include "../wifi.h"
>> +#include <linux/module.h>
>> +
>> +MODULE_AUTHOR("Realtek WlanFAE <wlanfae@realtek.com>");
>> +MODULE_LICENSE("GPL");
>> +MODULE_DESCRIPTION("Realtek 8192D 802.11an common routines");
> 
> Not sure why you emphasize '802.11an' instead of just '802.11n'.
> 
> 

I saw somewhere a dual-band chip described as 802.11an.
It seemed like a good idea. Should I change it?