All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan Hoffmann <sho@relinux.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] pkg-infra: rename <pkg>-rsync to <pkg>-extract
Date: Mon, 12 Nov 2012 09:27:58 +0100	[thread overview]
Message-ID: <50A0B30E.3090308@relinux.de> (raw)
In-Reply-To: <1350225704-5693-1-git-send-email-arnout@mind.be>

Am 14.10.2012 16:41, schrieb Arnout Vandecappelle (Essensium/Mind):
> The legal-info target (and possibly others as well) depends on
> <pkg>-extract to make sure the license file is available.  However,
> when <PKG>_OVERRIDE_SRCDIR is active, the <pkg>-extract target
> doesn't exist.
>
> To solve this, we just call the target that rsyncs the source
> <pkg>-extract.
>
> While we're at it, also add a <pkg>-patch target (which is equivalent
> to <pkg>-extract).  That avoids the same problem in the future if
> something starts depending on <pkg>-patch.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> ---
>  package/pkg-generic.mk |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index ffe7dfb..c2c1b06 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -378,9 +378,11 @@ else
>  $(1)-configure:		$(1)-depends \
>  			$$($(2)_TARGET_CONFIGURE)
>  
> -$(1)-depends:		$(1)-rsync $$($(2)_DEPENDENCIES)
> +$(1)-depends:		$(1)-extract $$($(2)_DEPENDENCIES)
>  
> -$(1)-rsync:		$$($(2)_TARGET_RSYNC)
> +$(1)-patch:		$(1)-extract
> +
> +$(1)-extract:		$$($(2)_TARGET_RSYNC)
>  
>  $(1)-source:		$$($(2)_TARGET_RSYNC_SOURCE)
>  endif
Hello,

this does not fix my issue, not even after doing a "make clean".

> LANG=C make legal-info
> mkdir -p /home/stephan/Dokumente/BeagleBone/buildroot/output/target
> if ! [ -d
> "/home/stephan/Dokumente/BeagleBone/buildroot/output/target/bin" ]; then \
>                 if [ -d
> "/home/stephan/Dokumente/BeagleBone/buildroot/fs/skeleton" ]; then \
>                         cp -fa
> /home/stephan/Dokumente/BeagleBone/buildroot/fs/skeleton/*
> /home/stephan/Dokumente/BeagleBone/buildroot/output/target/; \
>                 fi; \
>         fi
> find /home/stephan/Dokumente/BeagleBone/buildroot/output/target -type
> d -name CVS -print0 -o -name .svn -print0 | xargs -0 rm -rf
> find /home/stephan/Dokumente/BeagleBone/buildroot/output/target -type
> f \( -name .empty -o -name '*~' \) -print0 | xargs -0 rm -rf
> touch /home/stephan/Dokumente/BeagleBone/buildroot/output/build/.root
> >>>   Collecting legal info
<snip>
> >>> linux custom Syncing from source dir
> /home/stephan/Dokumente/BeagleBone/kernel/kernel
> rsync -au /home/stephan/Dokumente/BeagleBone/kernel/kernel/
> /home/stephan/Dokumente/BeagleBone/buildroot/output/build/linux-custom
> cp: cannot stat `/home/stephan/Dokumente/dl/linux-custom.tar.gz': No
> such file or directory
> make: *** [linux-legal-info] Error 1

Regards

Stephan

-- 
reLinux     -    Stephan Hoffmann
Am Schmidtgrund 124    50765 K?ln
Tel. +49.221.95595-19    Fax: -64
www.reLinux.de     sho at reLinux.de


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: defconfig
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20121112/c4961bf1/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: local.mk
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20121112/c4961bf1/attachment-0001.ksh>

  parent reply	other threads:[~2012-11-12  8:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11  8:19 [Buildroot] make legal-info fails when override is active Stephan Hoffmann
2012-10-14 14:41 ` [Buildroot] [PATCH] pkg-infra: rename <pkg>-rsync to <pkg>-extract Arnout Vandecappelle
2012-10-14 18:01   ` Thomas Petazzoni
2012-10-14 21:00     ` Arnout Vandecappelle
2012-10-14 21:06       ` Thomas Petazzoni
2012-10-14 21:19         ` [Buildroot] [PATCH v2] pkg-infra: add <pkg>-extract and <pkg>-patch targets to OVERRIDE support Arnout Vandecappelle
2012-10-14 21:42           ` Thomas Petazzoni
2012-10-15 12:38           ` Luca Ceresoli
2012-11-12  8:27   ` Stephan Hoffmann [this message]
2012-11-13 23:48     ` [Buildroot] [PATCH] pkg-infra: rename <pkg>-rsync to <pkg>-extract Arnout Vandecappelle
2012-11-14  8:20       ` Stephan Hoffmann
2012-12-03  9:58         ` Stephan Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A0B30E.3090308@relinux.de \
    --to=sho@relinux.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.