From mboxrd@z Thu Jan  1 00:00:00 1970
From: Clemens Ladisch <clemens@ladisch.de>
Subject: Re: Help requested: new HSS1394 MIDI back-end
Date: Mon, 12 Nov 2012 12:33:47 +0100
Message-ID: <50A0DE9B.8010906@ladisch.de>
References: <94aa86f3-5257-402a-a094-f58fccdeb846@email.android.com>
 <38538c62-f01e-4743-be92-aea79d61085e@email.android.com>
 <4FC5AC47.4060606@mixxx.org> <4FC5C9C8.1000604@ladisch.de>
 <4FC7CDC1.8020606@ladisch.de> <4FD2F324.7070402@mixxx.org>
 <4FD32E76.3090304@ladisch.de> <4FD49A51.3050809@ladisch.de>
 <5087D5D2.6020208@mixxx.org> <508991BD.5090101@ladisch.de>
 <s5hfw4fi27h.wl%tiwai@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by alsa0.perex.cz (Postfix) with ESMTP id 86FE4264F01
 for <alsa-devel@alsa-project.org>; Mon, 12 Nov 2012 12:33:49 +0100 (CET)
In-Reply-To: <s5hfw4fi27h.wl%tiwai@suse.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Takashi Iwai <tiwai@suse.de>
Cc: "Sean M. Pappalardo - D.J. Pegasus" <spappalardo@mixxx.org>, alsa-devel@alsa-project.org, linux1394-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

Takashi Iwai wrote:
> Clemens Ladisch wrote:
>>
>> +static int scs_init_hss_address(struct scs *scs)
>> +{
>> +	u8 data[8];
>> +	int err;
>> +
>> +	*(__be64 *)data = cpu_to_be64(scs->hss_handler.offset);
>
> Wouldn't it be safer to use unaligned access or a union?

Oops, indeed.  But safest would be to avoid playing byte-array games:

  __be64 data = cpu_to_be64(((u64)HSS1394_TAG_CHANGE_ADDRESS << 56) |
                            scs->hss_handler.offset);

Now fixed in the same branch.


Regards,
Clemens