From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] qemu-nbd: Initialise main loop earlier
Date: Mon, 12 Nov 2012 13:29:45 +0100 [thread overview]
Message-ID: <50A0EBB9.3050907@redhat.com> (raw)
In-Reply-To: <1352723015-13007-1-git-send-email-kwolf@redhat.com>
Il 12/11/2012 13:23, Kevin Wolf ha scritto:
> Since the latest AIO changes qemu-nbd would segfault because
> bdrv_init() requires qemu_aio_context to be initialised.
Thanks... I had this in my NBD queue, going to send it out later.
Paolo
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> qemu-nbd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index 15bcd08..80f08d8 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c
> @@ -539,6 +539,7 @@ int main(int argc, char **argv)
> snprintf(sockpath, 128, SOCKET_PATH, basename(device));
> }
>
> + qemu_init_main_loop();
> bdrv_init();
> atexit(bdrv_close_all);
>
> @@ -584,7 +585,6 @@ int main(int argc, char **argv)
> memset(&client_thread, 0, sizeof(client_thread));
> }
>
> - qemu_init_main_loop();
> qemu_set_fd_handler2(fd, nbd_can_accept, nbd_accept, NULL,
> (void *)(uintptr_t)fd);
>
>
prev parent reply other threads:[~2012-11-12 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 12:23 [Qemu-devel] [PATCH] qemu-nbd: Initialise main loop earlier Kevin Wolf
2012-11-12 12:29 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A0EBB9.3050907@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.