All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ortwin Glück" <odi-L693kI9kcNY@public.gmane.org>
To: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/nouveau: fix crash with noaccel=1
Date: Mon, 12 Nov 2012 19:12:01 +0100	[thread overview]
Message-ID: <50A13BF1.50202@odi.ch> (raw)
In-Reply-To: <20121111190009.GD3530-OI9uyE9O0yo@public.gmane.org>

I am confirming that it fixes the problem.

Thanks!

Ortwin

On 11.11.2012 20:00, Marcin Slusarz wrote:
>
> Reported-by: Ortwin Glück <odi@odi.ch>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> ---
>   drivers/gpu/drm/nouveau/nouveau_abi16.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_abi16.c b/drivers/gpu/drm/nouveau/nouveau_abi16.c
> index cc79c79..cbf1fc6 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_abi16.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_abi16.c
> @@ -241,6 +241,10 @@ nouveau_abi16_ioctl_channel_alloc(ABI16_IOCTL_ARGS)
>
>   	if (unlikely(!abi16))
>   		return -ENOMEM;
> +
> +	if (!drm->channel)
> +		return nouveau_abi16_put(abi16, -ENODEV);
> +
>   	client = nv_client(abi16->client);
>
>   	if (init->fb_ctxdma_handle == ~0 || init->tt_ctxdma_handle == ~0)
>
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

      parent reply	other threads:[~2012-11-12 18:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-11 19:00 [PATCH] drm/nouveau: fix crash with noaccel=1 Marcin Slusarz
     [not found] ` <20121111190009.GD3530-OI9uyE9O0yo@public.gmane.org>
2012-11-12 18:12   ` Ortwin Glück [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A13BF1.50202@odi.ch \
    --to=odi-l693ki9kcny@public.gmane.org \
    --cc=marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.