From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39747)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TYE01-0000L8-W8
	for qemu-devel@nongnu.org; Tue, 13 Nov 2012 05:45:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TYDzy-0003gF-Tv
	for qemu-devel@nongnu.org; Tue, 13 Nov 2012 05:45:45 -0500
Received: from mail-pa0-f45.google.com ([209.85.220.45]:55138)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TYDzy-0003g4-MT
	for qemu-devel@nongnu.org; Tue, 13 Nov 2012 05:45:42 -0500
Received: by mail-pa0-f45.google.com with SMTP id fb10so4814107pad.4
	for <qemu-devel@nongnu.org>; Tue, 13 Nov 2012 02:45:41 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50A224CE.5080708@redhat.com>
Date: Tue, 13 Nov 2012 11:45:34 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <50A0E8C20200009100082E55@novprvoes0310.provo.novell.com>
In-Reply-To: <50A0E8C20200009100082E55@novprvoes0310.provo.novell.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Charles Arnold <carnold@suse.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com

Il 12/11/2012 20:17, Charles Arnold ha scritto:
> Ping?
> 
> Is this ok?
> 
> - Charles
> 
>>>> On 11/2/2012 at 09:54 AM, in message <50A0E829.5B74.0091.0@suse.com>, Charles
> Arnold wrote: 
>> block/vpc: Initialize the uuid field in the footer with a generated uuid.
>>
>> Signed-off-by: Charles Arnold <carnold@suse.com>
>>
>> diff --git a/block/vpc.c b/block/vpc.c
>> index b6bf52f..f14c6ae 100644
>> --- a/block/vpc.c
>> +++ b/block/vpc.c
>> @@ -26,6 +26,9 @@
>>  #include "block_int.h"
>>  #include "module.h"
>>  #include "migration.h"
>> +#if defined(CONFIG_UUID)
>> +#include <uuid/uuid.h>
>> +#endif
>>  
>>  /**************************************************************/
>>  
>> @@ -739,7 +742,9 @@ static int vpc_create(const char *filename, 
>> QEMUOptionParameter *options)
>>  
>>      footer->type = be32_to_cpu(disk_type);
>>  
>> -    /* TODO uuid is missing */
>> +#if defined(CONFIG_UUID)
>> +    uuid_generate(footer->uuid);
>> +#endif
>>  
>>      footer->checksum = be32_to_cpu(vpc_checksum(buf, HEADER_SIZE));
>>  

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>