All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Avi Kivity <avi@redhat.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] qemu and transparent huge pages
Date: Tue, 13 Nov 2012 20:38:53 +0400	[thread overview]
Message-ID: <50A2779D.3070105@msgid.tls.msk.ru> (raw)
In-Reply-To: <20121113143053.GA6321@ohm.aurel32.net>

On 13.11.2012 18:30, Aurelien Jarno wrote:
> Isn't ad0b5321f1f797274603ebbe20108b0750baee94 enough?

Oh.  It has been applied.  I expected it will be ignored
just like my patch has been.

No, it is not enough: that patch alone does nothing for
the alignment on at least x86, which is necessary for
hugepages to work.  My patch _also_ fixes alignment issue.

Where to apply MADV_HUGEPAGE is a different question.
I don't know which layer it is best to apply it to.

Thanks,

/mjt

> On Mon, Nov 12, 2012 at 07:18:49PM +0400, Michael Tokarev wrote:
>> Ping^2 ?
>>
>> Thanks,
>>
>> /mjt
>>
>> 16.09.2012 15:19, Michael Tokarev wrote:
>>> So, is the patch okay?
>>>
>>> Thanks,
>>>
>>> /mjt
>>>
>>> On 15.08.2012 19:03, Michael Tokarev wrote:
>>>> On 15.08.2012 18:26, Avi Kivity wrote:
>>>>> On 08/15/2012 05:22 PM, Michael Tokarev wrote:
>>>>>
>>>>>>>
>>>>>>> Please provide extra info, like the setting of
>>>>>>> /sys/kernel/mm/transparent_hugepage/enabled.
>>>>>>
>>>>>> That was it - sort of.  Default value here is enabled=madvise.
>>>>>> When setting it to always the effect finally started appearing,
>>>>>> so it is actually working.
>>>>>>
>>>>>> But can't qemu set MADV_HUGEPAGE flag too, so it works automatically?
>>>>>
>>>>> It can and should.
>>>>
>>>> Something like the attached patch?
>>>>
>>>> Thanks,
>>>>
>>>> /mjt
>>>
>>
>>
>>
> 

  reply	other threads:[~2012-11-13 16:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-15 12:45 [Qemu-devel] qemu and transparent huge pages Michael Tokarev
2012-08-15 12:51 ` Avi Kivity
2012-08-15 14:22   ` Michael Tokarev
2012-08-15 14:26     ` Avi Kivity
2012-08-15 15:03       ` Michael Tokarev
2012-08-15 15:06         ` Michael Tokarev
2012-09-16 11:19         ` Michael Tokarev
2012-11-12 15:18           ` Michael Tokarev
2012-11-13 14:30             ` Aurelien Jarno
2012-11-13 16:38               ` Michael Tokarev [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-08-15 12:40 Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A2779D.3070105@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=aurelien@aurel32.net \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.