From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33092)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TYKcy-0002hW-ST
	for qemu-devel@nongnu.org; Tue, 13 Nov 2012 12:50:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TYKcv-0003kl-Pu
	for qemu-devel@nongnu.org; Tue, 13 Nov 2012 12:50:24 -0500
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:34845)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TYKcv-0003kL-J2
	for qemu-devel@nongnu.org; Tue, 13 Nov 2012 12:50:21 -0500
Message-ID: <50A28856.6040502@weilnetz.de>
Date: Tue, 13 Nov 2012 18:50:14 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1352796133-956-1-git-send-email-kraxel@redhat.com>
	<1352796133-956-3-git-send-email-kraxel@redhat.com>
In-Reply-To: <1352796133-956-3-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/6] pixman: pass tools to configure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org

Am 13.11.2012 09:42, schrieb Gerd Hoffmann:
> Complete the set of compiler tool names in config-host.mak,
> pass them to pixman configure to make sure cross builds work.
> Based on a patch from Blue Swirl.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>   Makefile  |    2 +-
>   configure |    4 ++++
>   2 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index ca14a21..7b267c9 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -122,7 +122,7 @@ subdir-pixman: pixman/Makefile
>   	$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C pixman V="$(V)" all,)
>   
>   pixman/Makefile: $(SRC_PATH)/pixman/configure
> -	(cd pixman; $(SRC_PATH)/pixman/configure --disable-shared --enable-static)
> +	(cd pixman; CC="$(CC)" LD="$(LD)" AR="$(AR)" NM="$(NM)" RANLIB="$(RANLIB)" $(SRC_PATH)/pixman/configure --disable-shared --enable-static)

An alternate solution (which works in my build environment) is passing
--host=... (value derived from QEMU cross_prefix) to the pixman configure.


>   
>   $(SRC_PATH)/pixman/configure:
>   	(cd $(SRC_PATH)/pixman; autoreconf -v --install)
> diff --git a/configure b/configure
> index 18faded..e7ca78b 100755
> --- a/configure
> +++ b/configure
> @@ -252,8 +252,10 @@ done
>   
>   cc="${CC-${cross_prefix}gcc}"
>   ar="${AR-${cross_prefix}ar}"
> +nm="${AR-${cross_prefix}nm}"

NM instead of AR?

>   objcopy="${OBJCOPY-${cross_prefix}objcopy}"
>   ld="${LD-${cross_prefix}ld}"
> +ranlib="${LD-${cross_prefix}ranlib}"

RANLIB instead of LD?

>   libtool="${LIBTOOL-${cross_prefix}libtool}"
>   strip="${STRIP-${cross_prefix}strip}"
>   windres="${WINDRES-${cross_prefix}windres}"
> @@ -3635,8 +3637,10 @@ echo "CC_I386=$cc_i386" >> $config_host_mak
>   echo "HOST_CC=$host_cc" >> $config_host_mak
>   echo "OBJCC=$objcc" >> $config_host_mak
>   echo "AR=$ar" >> $config_host_mak
> +echo "NM=$nm" >> $config_host_mak
>   echo "OBJCOPY=$objcopy" >> $config_host_mak
>   echo "LD=$ld" >> $config_host_mak
> +echo "RANLIB=$ranlib" >> $config_host_mak
>   echo "WINDRES=$windres" >> $config_host_mak
>   echo "LIBTOOL=$libtool" >> $config_host_mak
>   echo "CFLAGS=$CFLAGS" >> $config_host_mak