From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYKtc-00088U-2h for qemu-devel@nongnu.org; Tue, 13 Nov 2012 13:07:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYKtZ-0000S6-0C for qemu-devel@nongnu.org; Tue, 13 Nov 2012 13:07:35 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:52935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYKtY-0000Rx-Pm for qemu-devel@nongnu.org; Tue, 13 Nov 2012 13:07:32 -0500 Message-ID: <50A28C61.5040201@weilnetz.de> Date: Tue, 13 Nov 2012 19:07:29 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1352796133-956-1-git-send-email-kraxel@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 0/6] pixman build fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Peter Maydell , qemu-devel@nongnu.org Am 13.11.2012 18:31, schrieb Peter Maydell: > On 13 November 2012 08:42, Gerd Hoffmann wrote: >> This patch series fixes the build issues with the internal pixman >> submodule. It also adds licensing info to the qemu-pixman.[ch] files. > These look OK (and I've tested that we can crosscompile using > internal pixman in a separate builddirectory). > Reviewed-by: Peter Maydell > > One remaining problem it would be nice to fix (probably as a > separate patch given this lot is at the pullreq stage): > "make distclean" in qemu doesn't do a distclean in the pixman/ > directory. > > -- PMM I just sent reviews for patches 1 and 2. IMHO patch 2 needs some small corrections, and patch 1 can optionally be improved. With at least the corrections, you may add Reviewed-by: Stefan Weil The patch series clearly improves the current build code. As Peter noted, more problems can be addressed later. Cheers Stefan