All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Michael Trimarchi <michael@amarulasolutions.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: HIFACE family driver
Date: Wed, 14 Nov 2012 20:44:10 +0800	[thread overview]
Message-ID: <50A3921A.4030907@gmail.com> (raw)
In-Reply-To: <50A3750A.70401@amarulasolutions.com>

Hi Michael,

On 14.11.2012 18:40, Michael Trimarchi wrote:
> I have written in my spare time an alsa driver for HIFACE devices
> family. Now I'm not an alsa expert and I would like to know if you
> think that it's useful to include it in mainline
> 
> https://github.com/panicking/snd-usb-asyncaudio
> 
> The list of usb devices supported
> 
> https://github.com/panicking/snd-usb-asyncaudio/blob/master/chip.c

We've already seen this - very cool!

> The main difference is that I need to use bulk message to talk to the
> usb dongle and ofcourse there are a lot of improvement that we can do
> on it. I have already tested on several kernel version and it's
> already included in some linux distribution. Wait for some feedback
> ;)

More than welcome :) You should submit your current version of the code
in digestable pieces. Maybe the basic driver structure first, and then
put individual features into additional patches if possible. That way,
things can be reviewed in-line on the mailing list.


Thanks,
Daniel

  parent reply	other threads:[~2012-11-14 12:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-14 10:40 HIFACE family driver Michael Trimarchi
2012-11-14 11:15 ` Grant Diffey
2012-11-14 11:40   ` Michael Trimarchi
2012-11-14 12:44 ` Daniel Mack [this message]
2012-12-04 10:22   ` Michael Trimarchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A3921A.4030907@gmail.com \
    --to=zonque@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=michael@amarulasolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.