From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36590)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TYdZ7-000353-Vc
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 09:03:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TYdZ4-0005jp-TD
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 09:03:41 -0500
Received: from cantor2.suse.de ([195.135.220.15]:48542 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TYdZ4-0005jh-Mw
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 09:03:38 -0500
Message-ID: <50A3A4B6.9060204@suse.de>
Date: Wed, 14 Nov 2012 15:03:34 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1352473012-20500-1-git-send-email-ehabkost@redhat.com>
	<1352473012-20500-8-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1352473012-20500-8-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, qemu-devel@nongnu.org, blauwirbel@gmail.com, Anthony Liguori <anthony@codemonkey.ws>, Igor Mammedov <imammedo@redhat.com>

Am 09.11.2012 15:56, schrieb Eduardo Habkost:
> module.h is where machine_init() is defined, but qemu-fsdev-dummy.c
> doesn't include it.
>=20
> The header is probably being included by accident because some other
> headers are including qemu-common.h, but those headers should eventuall=
y
> stop including qemu-common.h.
>=20
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Acked-by: Andreas F=E4rber <afaerber@suse.de>

I'm surprised about this machine_init() use case outside a machine though=
...

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg