From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41497)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TYfbP-0005at-4g
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 11:14:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TYfbM-0005GQ-2P
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 11:14:11 -0500
Received: from cantor2.suse.de ([195.135.220.15]:54270 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TYfbL-0005FY-Se
	for qemu-devel@nongnu.org; Wed, 14 Nov 2012 11:14:08 -0500
Message-ID: <50A3C348.4000902@suse.de>
Date: Wed, 14 Nov 2012 17:14:00 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1352473012-20500-1-git-send-email-ehabkost@redhat.com>
	<1352473012-20500-13-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1352473012-20500-13-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 12/24] qga/channel-posix.c: include headers
	it needs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, qemu-devel@nongnu.org, blauwirbel@gmail.com, Anthony Liguori <anthony@codemonkey.ws>, Igor Mammedov <imammedo@redhat.com>

Am 09.11.2012 15:56, schrieb Eduardo Habkost:
> Include:
>  - <errno.h> for errno
>  - <unistd.h> & <fcntl.h> for fcntl()
>  - "qemu-stdio.h" for qemu_open()
>=20
> Some of those headers were probably being included by accident because
> some other headers were including qemu-common.h, but those headers
> should eventually stop including qemu-common.h.
>=20
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  qga/channel-posix.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/qga/channel-posix.c b/qga/channel-posix.c
> index d152827..2a68451 100644
> --- a/qga/channel-posix.c
> +++ b/qga/channel-posix.c
> @@ -1,5 +1,9 @@
>  #include <glib.h>
>  #include <termios.h>
> +#include <errno.h>
> +#include <unistd.h>
> +#include <fcntl.h>
> +#include "qemu-stdio.h"
>  #include "qemu_socket.h"
>  #include "qga/channel.h"
> =20

Since the qemu-stdio.h patch was under debate, I've posted a patch
moving qemu_open() and its companion qemu_close() to osdep.h as
suggested by Igor - uses osdep.h here works fine then. Rest looks good.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg