From: Stephen Warren <swarren@wwwdotorg.org>
To: Bryan Wu <cooloney@gmail.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>
Cc: Marek Belisko <marek.belisko@open-nandra.com>,
Stephen Warren <swarren@nvidia.com>,
rpurdie@rpsys.net, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v3 2/2] Add documentation for tca6507 devicetree bindings.
Date: Wed, 14 Nov 2012 12:26:39 -0700 [thread overview]
Message-ID: <50A3F06F.20809@wwwdotorg.org> (raw)
In-Reply-To: <CAK5ve-L=SBFEfoY8oKYYb-dFCWf=-Eb-qMFdWdiBO3wfaR3tDA@mail.gmail.com>
On 11/13/2012 06:05 PM, Bryan Wu wrote:
> It looks fine to me, but I need a DT maintainer's ack. Stephen, could
> you help on this. I will merge this patch via my tree.
I'm not actually a DT maintainer; I CC'd Grant and Rob. Marek probably
wants to repost the whole patch to them. Comments below.
>> diff --git a/Documentation/devicetree/bindings/leds/tca6507.txt b/Documentation/devicetree/bindings/leds/tca6507.txt
...
>> +LED sub-node properties:
...
>> + string defining the trigger assigned to the LED. Current triggers are:
>> + "backlight" - LED will act as a back-light, controlled by the framebuffer
>> + system
>> + "default-on" - LED will turn on
>> + "heartbeat" - LED "double" flashes at a load average based rate
>> + "ide-disk" - LED indicates disk activity
>> + "timer" - LED flashes at a fixed, configurable rate
It would be useful to point at a single canonical document that
describes the triggers, rather than duplicating the list into every binding.
Aside from that, I think this looks reasonable.
Oh, looking at Documentation/devicetree/bindings/gpio/led.txt, should a
default-state property be supported?
next prev parent reply other threads:[~2012-11-14 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 21:25 [PATCH v3 1/2] leds/tca6507: Add support for devicetree Marek Belisko
2012-11-12 21:25 ` [PATCH v3 2/2] Add documentation for tca6507 devicetree bindings Marek Belisko
2012-11-14 1:05 ` Bryan Wu
2012-11-14 19:26 ` Stephen Warren [this message]
[not found] ` <50A3F06F.20809-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-11-14 22:50 ` Bryan Wu
2012-11-14 22:50 ` Bryan Wu
2012-11-15 18:12 ` Grant Likely
2012-11-15 18:12 ` Grant Likely
2012-11-14 1:01 ` [PATCH v3 1/2] leds/tca6507: Add support for devicetree Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A3F06F.20809@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=cooloney@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=marek.belisko@open-nandra.com \
--cc=rob.herring@calxeda.com \
--cc=rpurdie@rpsys.net \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.