From: Patrice Chotard <patrice.chotard@sfr.fr>
To: Frédéric <fma@gbiloba.org>
Cc: linux-media@vger.kernel.org
Subject: Re: Support for Terratec Cinergy 2400i DT in kernel 3.x
Date: Wed, 14 Nov 2012 21:50:17 +0100 [thread overview]
Message-ID: <50A40409.6000400@sfr.fr> (raw)
In-Reply-To: <201211141036.06971.fma@gbiloba.org>
Yes, there are differences, simply because algorithms which use these
tables are different ;-).
On 14/11/2012 10:36, Frédéric wrote:
> Le mercredi 14 novembre 2012, Frédéric a écrit :
>
>> I had a look at your patches. I don't see the '.fw_version' param anymore
>> in the 'ngene_info' structure... Is it normal?
>
> I also noticed some differences in the PLL presets:
>
> In your patch:
>
> .entries = {
> { 305000000, 166667, 0xb4, 0x12 },
> { 405000000, 166667, 0xbc, 0x12 },
> { 445000000, 166667, 0xbc, 0x12 },
> { 465000000, 166667, 0xf4, 0x18 },
> { 735000000, 166667, 0xfc, 0x18 },
> { 835000000, 166667, 0xbc, 0x18 },
> { 999999999, 166667, 0xfc, 0x18 },
> },
>
> In original patch:
>
> if (freq<177000000 || freq>858000000)
> return -EINVAL;
> else if (freq<305000000) { c1=0xb4; c2=0x12; }
> else if (freq<405000000) { c1=0xbc; c2=0x12; }
> else if (freq<445000000) { c1=0xf4; c2=0x12; }
> else if (freq<465000000) { c1=0xfc; c2=0x12; }
> else if (freq<735000000) { c1=0xbc; c2=0x18; }
> else if (freq<835000000) { c1=0xf4; c2=0x18; }
> else { c1=0xfc; c2=0x18; }
>
next prev parent reply other threads:[~2012-11-14 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 9:40 Support for Terratec Cinergy 2400i DT in kernel 3.x Frédéric
2012-11-13 21:51 ` Patrice Chotard
2012-11-14 8:48 ` Frédéric
2012-11-14 9:36 ` Frédéric
2012-11-14 20:50 ` Patrice Chotard [this message]
2012-11-14 20:46 ` Patrice Chotard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A40409.6000400@sfr.fr \
--to=patrice.chotard@sfr.fr \
--cc=fma@gbiloba.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.