From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamezawa Hiroyuki Date: Thu, 15 Nov 2012 08:48:39 +0000 Subject: Re: [patch 4/4] mm, oom: remove statically defined arch functions of same name Message-Id: <50A4AC67.5000102@jp.fujitsu.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Rientjes Cc: Andrew Morton , Greg Kroah-Hartman , KOSAKI Motohiro , Michal Hocko , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Benjamin Herrenschmidt , Paul Mackerras , Paul Mundt , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org (2012/11/14 18:15), David Rientjes wrote: > out_of_memory() is a globally defined function to call the oom killer. > x86, sh, and powerpc all use a function of the same name within file > scope in their respective fault.c unnecessarily. Inline the functions > into the pagefault handlers to clean the code up. > > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Thomas Gleixner > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Paul Mundt > Signed-off-by: David Rientjes I think this is good. Reviewed-by: KAMEZAWA Hiroyuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fgwmail7.fujitsu.co.jp (fgwmail7.fujitsu.co.jp [192.51.44.37]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 69DC02C0617 for ; Thu, 15 Nov 2012 20:41:58 +1100 (EST) Received: from fgwmail6.fujitsu.co.jp (fgwmail6.fujitsu.co.jp [192.51.44.36]) by fgwmail7.fujitsu.co.jp (Postfix) with ESMTP id 5B89D1793210 for ; Thu, 15 Nov 2012 17:49:18 +0900 (JST) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id EC1FE3EE0C1 for ; Thu, 15 Nov 2012 17:49:12 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id D1DE445DEC3 for ; Thu, 15 Nov 2012 17:49:12 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id A914C45DEBE for ; Thu, 15 Nov 2012 17:49:12 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 95E591DB8048 for ; Thu, 15 Nov 2012 17:49:12 +0900 (JST) Received: from m1001.s.css.fujitsu.com (m1001.s.css.fujitsu.com [10.240.81.139]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 490031DB8041 for ; Thu, 15 Nov 2012 17:49:12 +0900 (JST) Message-ID: <50A4AC67.5000102@jp.fujitsu.com> Date: Thu, 15 Nov 2012 17:48:39 +0900 From: Kamezawa Hiroyuki MIME-Version: 1.0 To: David Rientjes Subject: Re: [patch 4/4] mm, oom: remove statically defined arch functions of same name References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Paul Mundt , linux-sh@vger.kernel.org, Greg Kroah-Hartman , x86@kernel.org, linux-kernel@vger.kernel.org, Michal Hocko , linux-mm@kvack.org, Ingo Molnar , Paul Mackerras , KOSAKI Motohiro , "H. Peter Anvin" , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Thomas Gleixner List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , (2012/11/14 18:15), David Rientjes wrote: > out_of_memory() is a globally defined function to call the oom killer. > x86, sh, and powerpc all use a function of the same name within file > scope in their respective fault.c unnecessarily. Inline the functions > into the pagefault handlers to clean the code up. > > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Thomas Gleixner > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Paul Mundt > Signed-off-by: David Rientjes I think this is good. Reviewed-by: KAMEZAWA Hiroyuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx169.postini.com [74.125.245.169]) by kanga.kvack.org (Postfix) with SMTP id A51BC6B00A4 for ; Thu, 15 Nov 2012 03:49:14 -0500 (EST) Received: from m1.gw.fujitsu.co.jp (unknown [10.0.50.71]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id F08C23EE0C3 for ; Thu, 15 Nov 2012 17:49:12 +0900 (JST) Received: from smail (m1 [127.0.0.1]) by outgoing.m1.gw.fujitsu.co.jp (Postfix) with ESMTP id D5D6445DE5C for ; Thu, 15 Nov 2012 17:49:12 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (s1.gw.fujitsu.co.jp [10.0.50.91]) by m1.gw.fujitsu.co.jp (Postfix) with ESMTP id A108745DE58 for ; Thu, 15 Nov 2012 17:49:12 +0900 (JST) Received: from s1.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 8D375E08002 for ; Thu, 15 Nov 2012 17:49:12 +0900 (JST) Received: from m1001.s.css.fujitsu.com (m1001.s.css.fujitsu.com [10.240.81.139]) by s1.gw.fujitsu.co.jp (Postfix) with ESMTP id 425EFE08005 for ; Thu, 15 Nov 2012 17:49:12 +0900 (JST) Message-ID: <50A4AC67.5000102@jp.fujitsu.com> Date: Thu, 15 Nov 2012 17:48:39 +0900 From: Kamezawa Hiroyuki MIME-Version: 1.0 Subject: Re: [patch 4/4] mm, oom: remove statically defined arch functions of same name References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Andrew Morton , Greg Kroah-Hartman , KOSAKI Motohiro , Michal Hocko , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Benjamin Herrenschmidt , Paul Mackerras , Paul Mundt , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org (2012/11/14 18:15), David Rientjes wrote: > out_of_memory() is a globally defined function to call the oom killer. > x86, sh, and powerpc all use a function of the same name within file > scope in their respective fault.c unnecessarily. Inline the functions > into the pagefault handlers to clean the code up. > > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Thomas Gleixner > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Paul Mundt > Signed-off-by: David Rientjes I think this is good. Reviewed-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992966Ab2KOItP (ORCPT ); Thu, 15 Nov 2012 03:49:15 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:36777 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992537Ab2KOItN (ORCPT ); Thu, 15 Nov 2012 03:49:13 -0500 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.8.4 Message-ID: <50A4AC67.5000102@jp.fujitsu.com> Date: Thu, 15 Nov 2012 17:48:39 +0900 From: Kamezawa Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: David Rientjes CC: Andrew Morton , Greg Kroah-Hartman , KOSAKI Motohiro , Michal Hocko , Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Benjamin Herrenschmidt , Paul Mackerras , Paul Mundt , x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch 4/4] mm, oom: remove statically defined arch functions of same name References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2012/11/14 18:15), David Rientjes wrote: > out_of_memory() is a globally defined function to call the oom killer. > x86, sh, and powerpc all use a function of the same name within file > scope in their respective fault.c unnecessarily. Inline the functions > into the pagefault handlers to clean the code up. > > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Thomas Gleixner > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Paul Mundt > Signed-off-by: David Rientjes I think this is good. Reviewed-by: KAMEZAWA Hiroyuki