From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] usb: host-linux: Ignore parsing errors of the device descriptors
Date: Thu, 15 Nov 2012 10:00:27 +0100 [thread overview]
Message-ID: <50A4AF2B.3020003@redhat.com> (raw)
In-Reply-To: <50A4A851.5000000@siemens.com>
On 11/15/12 09:31, Jan Kiszka wrote:
>> > I'd prefer to keep the error jump target to handle the parse error here.
>> > Dumping the reset there is fine with me, but I'd prefer this event being
>> > logged (trace point or stderr message or both) to ease trouble shooting
>> > in case a device doesn't behave as expected.
> That would be "over-logging" as we already record the individual
> reasons. There is simply no code to jump to after the refactoring.
Oh, right, we trace that already. Ok then.
Patch added to usb patch queue.
thanks,
Gerd
prev parent reply other threads:[~2012-11-15 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 8:23 [Qemu-devel] [PATCH] usb: host-linux: Ignore parsing errors of the device descriptors Jan Kiszka
2012-11-15 8:28 ` Gerd Hoffmann
2012-11-15 8:31 ` Jan Kiszka
2012-11-15 9:00 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A4AF2B.3020003@redhat.com \
--to=kraxel@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.