Re: [PATCH 4/4] regulator: fixed: Properly use input_supply parameter from device tree

[Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

On 11/15/2012 09:56 AM, Roger Quadros wrote:
> The device tree node will provide the input supply name as
> a string. Use that to populate the supply_name parameter of
> the regulator descriptor.
>
> Also correct the documentation to reflect the same.
>
> Signed-off-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
> CC: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> CC: Mark Brown <broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
> ---
>   		regulator-boot-on;
>   		gpio-open-drain;
> -		vin-supply = <&parent_reg>;
> +		vin-supply = "input-supply-name";

This is not correct as per the regulator binding. It says
  - <name>-supply: phandle to the parent supply/regulator node

So we need to pass the phandle rather than string.

Just for curiosity, why do you want this change? What is the issue are 
you facing.

This change will creates regression on many platform.


-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html