From: Jeff Garzik <jgarzik@pobox.com>
To: David Milburn <dmilburn@redhat.com>
Cc: linux-ide@vger.kernel.org, benh@kernel.crashing.org, caiqian@redhat.com
Subject: Re: [PATCH] sata_svw: check DMA start bit before reset
Date: Thu, 15 Nov 2012 23:55:09 -0500 [thread overview]
Message-ID: <50A5C72D.4020206@pobox.com> (raw)
In-Reply-To: <1351551622-1193-1-git-send-email-dmilburn@redhat.com>
On 10/29/2012 07:00 PM, David Milburn wrote:
> If kdump is triggered with pending IO, controller may not respond causing
> kdump to fail.
>
> http://marc.info/?l=linux-ide&m=133032255424658&w=2
>
> During error recovery ata_do_dev_read_id never completes due hang
> in mmio_insw.
>
> ata_do_dev_read_id
> ata_sff_data_xfer
> ioread16_rep
> mmio_insw
>
> if DMA start bit is cleared before reset, PIO command is successful
> and kdump succeeds.
>
> Signed-off-by: David Milburn <dmilburn@redhat.com>
> ---
> drivers/ata/sata_svw.c | 35 +++++++++++++++++++++++++++++++++++
> 1 files changed, 35 insertions(+), 0 deletions(-)
applied
prev parent reply other threads:[~2012-11-16 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 23:00 [PATCH] sata_svw: check DMA start bit before reset David Milburn
2012-11-16 4:55 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A5C72D.4020206@pobox.com \
--to=jgarzik@pobox.com \
--cc=benh@kernel.crashing.org \
--cc=caiqian@redhat.com \
--cc=dmilburn@redhat.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.