From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 1/5] ata: suspend/resume callbacks should be conditionally compiled on CONFIG_PM_SLEEP Date: Fri, 16 Nov 2012 00:48:11 -0500 Message-ID: <50A5D39B.4090007@pobox.com> References: <1350399545-11179-1-git-send-email-yuanhan.liu@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-vc0-f174.google.com ([209.85.220.174]:63041 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999Ab2KPFsP (ORCPT ); Fri, 16 Nov 2012 00:48:15 -0500 In-Reply-To: <1350399545-11179-1-git-send-email-yuanhan.liu@linux.intel.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Yuanhan Liu Cc: linux-kernel@vger.kernel.org, Viresh Kumar , linux-ide@vger.kernel.org, Fengguang Wu On 10/16/2012 10:59 AM, Yuanhan Liu wrote: > This will fix warnings like following when CONFIG_PM_SLEEP is not set: > > warning: 'xxx_suspend' defined but not used [-Wunused-function] > warning: 'xxx_resume' defined but not used [-Wunused-function] > > Because > SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn) > > Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM). > > Cc: Jeff Garzik > Cc: Viresh Kumar > Cc: linux-ide@vger.kernel.org > Signed-off-by: Yuanhan Liu > Signed-off-by: Fengguang Wu > --- > drivers/ata/ahci_platform.c | 2 +- > drivers/ata/pata_arasan_cf.c | 2 +- > drivers/ata/sata_highbank.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) applied