Re: [PATCH v2 01/22] brcmsmac: Introduce AMPDU sessions for assembling AMPDUs

["Arend van Spriel" <arend@broadcom.com>]

On 11/15/2012 03:07 PM, Seth Forshee wrote:
> AMPDU session allows MPDUs to be temporarily queued until either a full
> AMPDU has been collected or circumstances dictate that transmission
> should start with a partial AMPDU. Packets are added to the session by

I started reviewing this and reading this commit message got me 
wondering about the .flush() problems. I realized the flush would be a 
"circumstance" to start transmission of a partial AMPDU, but I am pretty 
sure it currently is not treated as such.

Regards,
Arend

> calling brcms_c_ampdu_add_frame(). brcms_c_ampdu_finalize() should be
> called to fix up the tx headers in the first and last packet before
> adding the packets to the DMA ring. brmcs_c_sendampdu() is converted to
> using AMPDU sessions.
>
> This patch has no real value on it's own, but is needed in preparation
> for elimination of the tx packet queue from brcmsmac.
>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> ---
>   drivers/net/wireless/brcm80211/brcmsmac/ampdu.c |  625 +++++++++++++----------
>   drivers/net/wireless/brcm80211/brcmsmac/ampdu.h |   26 +
>   2 files changed, 377 insertions(+), 274 deletions(-)