From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman
Date: Fri, 16 Nov 2012 18:08:26 +0800 [thread overview]
Message-ID: <50A6109A.6020902@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAFEAcA-4OvTkgAV-Jx0hZ6c8CaYG+rckpxHqK8_g6OqhQON=+A@mail.gmail.com>
于 2012-11-16 17:27, Peter Maydell 写道:
> On 16 November 2012 05:05, Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
>> Currently if pixman have no config.log inside, make file still
>> try to clean it resulting error. This patch fix it.
>>
>> - test -f pixman/config.log && make -C pixman distclean
>> + @if test -f pixman/config.log; \
>> + then \
>> + make -C pixman distclean;\
>> + fi
>
> These two bits of shellscript both do the same thing, don't they?
>
> -- PMM
>
Looks the same, but on my machine
make -C pixman distclean
got executed resulting error, I guess that is what original author
wants to avoid.
I'll conclude this patch into my libqblock patch serials to make
it easier to be reviwed.
--
Best Regards
Wenchao Xia
next prev parent reply other threads:[~2012-11-16 10:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 5:05 [Qemu-devel] [PATCH 0/2] Buildsystem fix Wenchao Xia
2012-11-16 5:05 ` [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman Wenchao Xia
2012-11-16 9:27 ` Peter Maydell
2012-11-16 10:08 ` Wenchao Xia [this message]
2012-11-16 10:16 ` Peter Maydell
2012-11-16 10:27 ` Wenchao Xia
2012-11-16 10:23 ` Paolo Bonzini
2012-11-16 10:26 ` Peter Maydell
2012-11-16 10:38 ` Gerd Hoffmann
2012-11-16 10:53 ` Wenchao Xia
2012-11-16 10:51 ` Wenchao Xia
2012-11-16 5:05 ` [Qemu-devel] [PATCH 2/2] Buildsystem clean tests directory clearly Wenchao Xia
2012-11-16 10:23 ` Paolo Bonzini
2012-11-16 10:29 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A6109A.6020902@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.