From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZJ78-00006B-3n for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:25:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZJ75-0004bI-1d for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:25:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZJ74-0004bE-QK for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:25:30 -0500 Message-ID: <50A61497.90003@redhat.com> Date: Fri, 16 Nov 2012 11:25:27 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <50A50806.5020309@redhat.com> <50A50CD7.4070104@siemens.com> In-Reply-To: <50A50CD7.4070104@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Hans de Goede , "qemu-devel@nongnu.org" On 11/15/12 16:40, Jan Kiszka wrote: > Hi Hans, > > On 2012-11-15 16:19, Hans de Goede wrote: >> Hi Jan, >> >> I just saw your $subject patch in Gerd's usb-next tree, and I've a question >> about it. The token should be enough to uniquely identify a device + ep, >> and unless a guest uses multiple qhs for a singe ep, that _should_ be enough. > > But what disallows that the guest issues multiple requests (QH + series > of TDs) for a single endpoint? I'm not finding any trace in the spec > that disallows this. And my special guest is stumbling over that > limitation in QEMU. The order which the TDs from the two QHs are filled is undefined I think, so why a guest would do that? I guess I'll push back the patch in the queue and don't include it into the 1.3 pull req until this is sorted. cheers, Gerd