From: Aaron Plattner <aplattner@nvidia.com>
To: dri-devel@lists.freedesktop.org
Subject: Abstracting buffer sharing mechanism from the drm drivers
Date: Fri, 16 Nov 2012 12:05:40 -0800 [thread overview]
Message-ID: <50A69C94.4040507@nvidia.com> (raw)
At the suggestion of a few drm developers, I'm looking at abstracting the buffer
sharing mechanism away from the individual drm drivers and treating it as a
low-level interface that kernel subsystems use to communicate, rather than as
something drivers should be accessing directly. This would also mean that they
wouldn't have to each implement their own set of dma_buf_ops, and the logic for
things like detecting that you're importing your own dma_buf would be written
once, in drm_prime.c and not in every driver's gem_prime_import function.
Of course, it's slightly difficult because each driver's implementation seems to
be subtly different.
* i915 uses its own special locking function, i915_mutex_lock_interruptible.
* nouveau and radeon pin the pages when the dma_buf is created, while i915 pins
them at map time.
* the vmap functions are different between i915 and radeon/nouveau, but it
looks like all they use the dma_buf object for is to find the GEM object.
Does it make sense to try to abstract the dma_buf parts of this? For
example, a hypothetical new drm_gem_map_dma_buf would call a hook that lets i915
do its i915_gem_wait_for_error thing, takes the lock, calls a new gem_get_pages
driver hook, does the dma_map_sg call, and handles the unlocking? I'll come up
with a more detailed proposal or patches if this sounds like a good idea.
--
Aaron
next reply other threads:[~2012-11-16 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 20:05 Aaron Plattner [this message]
2012-11-16 21:14 ` Abstracting buffer sharing mechanism from the drm drivers Jerome Glisse
2012-11-27 15:21 ` Aaron Plattner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A69C94.4040507@nvidia.com \
--to=aplattner@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.