From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta27u-0004Dw-SJ for qemu-devel@nongnu.org; Sun, 18 Nov 2012 05:29:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ta27r-0002Wc-Mi for qemu-devel@nongnu.org; Sun, 18 Nov 2012 05:29:22 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:39021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta27r-0002TI-GB for qemu-devel@nongnu.org; Sun, 18 Nov 2012 05:29:19 -0500 Message-ID: <50A8B87C.5000601@weilnetz.de> Date: Sun, 18 Nov 2012 11:29:16 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1353159697-3922-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1353159697-3922-1-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] rng-random: only build on POSIX platforms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , qemu-devel@nongnu.org Am 17.11.2012 14:41, schrieb Anthony Liguori: > There is no /dev/random on win32. > > Cc: Stefan Weil > Signed-off-by: Anthony Liguori > --- > backends/Makefile.objs | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/backends/Makefile.objs b/backends/Makefile.objs > index 875eebc..8836761 100644 > --- a/backends/Makefile.objs > +++ b/backends/Makefile.objs > @@ -1 +1,2 @@ > -common-obj-y += rng.o rng-random.o rng-egd.o > +common-obj-y += rng.o rng-egd.o > +common-obj-$(CONFIG_POSIX) += rng-random.o The patch fixes a build issue on w32 / w64, but the reason given is misleading: yes, Windows has no /dev files, but the MinGW library tries to emulate the most important interfaces from /dev. There is a /dev/random with MinGW, and it does what it is supposed to do. See this URL for more supported "devices": http://srv.onzk.net/linwin/apache-php3-mysql/CygWin_20b_98-4_Documents_OnLine/CygWin-Ug-Net/using-specialnames.html Regards Stefan W.