From: John Crispin <john@phrozen.org>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH v4 0/3] MIPS: BCM47xx: use gpiolib
Date: Sun, 18 Nov 2012 16:48:30 +0100 [thread overview]
Message-ID: <50A9034E.4050306@phrozen.org> (raw)
In-Reply-To: <50A8D8C9.1000802@hauke-m.de>
On 18/11/12 13:47, Hauke Mehrtens wrote:
> On 11/18/2012 12:05 PM, Rafał Miłecki wrote:
>> 2012/9/11 Hauke Mehrtens<hauke@hauke-m.de>:
>>> The original code implemented the GPIO interface itself and this caused
>>> some problems. With this patch gpiolib is used.
>>>
>>> This is based on mips/master.
>>>
>>> This should go through linux-mips, John W. Linville approved that
>>> for the bcma and ssb changes normally maintained in wireless-testing.
>>
>> Ping? Did it go upstream? I can't find that commits in
>> http://git.kernel.org/?p=linux/kernel/git/ralf/linux.git;a=summary
>>
> I talked to John Crispin in IRC, he does not like this patch and I will
> send a new version today.
>
> Hauke
>
>
Hi,
Without looking into the details of the code we agreed, that there was a
better solution to the ifdeferey embedded inside switch constructs, that
had no break statement.
John
prev parent reply other threads:[~2012-11-18 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 15:15 [PATCH v4 0/3] MIPS: BCM47xx: use gpiolib Hauke Mehrtens
2012-09-11 15:15 ` [PATCH v4 1/3] ssb: add function to return number of gpio lines Hauke Mehrtens
2012-09-11 15:15 ` [PATCH v4 2/3] bcma: add GPIO driver for SoCs Hauke Mehrtens
2012-09-11 15:15 ` [PATCH v4 3/3] MIPS: BCM47xx: rewrite GPIO handling and use gpiolib Hauke Mehrtens
2012-11-18 11:05 ` [PATCH v4 0/3] MIPS: BCM47xx: " Rafał Miłecki
2012-11-18 12:47 ` Hauke Mehrtens
2012-11-18 15:48 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A9034E.4050306@phrozen.org \
--to=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.