From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/3] SPL: Change description for spl command
Date: Mon, 19 Nov 2012 11:17:10 +0100 [thread overview]
Message-ID: <50AA0726.3080809@gmail.com> (raw)
In-Reply-To: <1353316265-24430-3-git-send-email-sbabic@denx.de>
Dear Stefano Babic,
On 19.11.2012 10:11, Stefano Babic wrote:
> Add a more descriptive text to the help of the spl
> command.
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>
> common/cmd_spl.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/common/cmd_spl.c b/common/cmd_spl.c
> index 9ec054a..b21d41d 100644
> --- a/common/cmd_spl.c
> +++ b/common/cmd_spl.c
> @@ -182,7 +182,11 @@ static int do_spl(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>
> U_BOOT_CMD(
> spl, 6 , 1, do_spl, "SPL configuration",
> - "export <img=atags|fdt> [kernel_addr] [initrd_addr] "
> - "[fdt_addr if <img> = fdt] - export a kernel parameter image\n"
> - "\t initrd_img can be set to \"-\" if fdt_addr without initrd img is"
> - "used");
> + "export <img=atags|fdt> [kernel_addr] [initrd_addr] [fdt_addr ]\n"
---------------------------------------------------------------------^
unnecessary blank
> + "\timg\t\t\"atags\" or \"fdt\"\n"
> + "\tkernel_addr\taddress where a kernel image is stored.\n"
> + "\t\t\tkernel is loaded as part of the boot process, but it is not started.\n"
> + "\tinitrd_addr\tAddress of initial ramdisk\n"
------------------------^
Capitalization should be uniform. Either change all other places to
capital beginning or start here with small letters.
> + "\t\t\tcan be set to \"-\" if fdt_addr without initrd img is used\n"
--------------------------------------------------------------^
I think we should write here either 'initrd image'/'initial ramdisk
image' or 'initrd_addr'. I know img is a well known abbreviation for
image, but in a descriptive text we should IMHO not abbreviate.
Additionally the sentence should stop with a full stop like the others do.
> + "\tfdt_addr\tin case of fdt, the address of the device tree.\n"
> + );
>
Best regards
Andreas Bie?mann
next prev parent reply other threads:[~2012-11-19 10:17 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 10:59 [U-Boot] [PATCH] Add README for the "Falcon" mode Stefano Babic
2012-11-12 11:35 ` Andreas Bießmann
2012-11-12 13:02 ` Stefano Babic
2012-11-12 13:33 ` Andreas Bießmann
2012-11-13 11:11 ` [U-Boot] [PATCH v2 1/2] " Stefano Babic
2012-11-13 11:11 ` [U-Boot] [PATCH v2 2/2] OMAP3: drop CONFIG_SPL_OS_BOOT_KEY and use local define Stefano Babic
2012-11-13 13:54 ` Thomas Weber
2012-11-13 13:13 ` [U-Boot] [PATCH v2 1/2] Add README for the "Falcon" mode Thomas Weber
2012-11-13 15:55 ` Andreas Bießmann
2012-11-13 17:08 ` Stefano Babic
2012-11-14 10:29 ` Otavio Salvador
2012-11-14 12:19 ` Stefano Babic
2012-11-14 12:22 ` Otavio Salvador
2012-11-19 9:11 ` [U-Boot] [PATCH v3 1/3] " Stefano Babic
2012-11-19 9:11 ` [U-Boot] [PATCH v3 2/3] OMAP3: drop CONFIG_SPL_OS_BOOT_KEY and use local define Stefano Babic
2012-11-19 9:11 ` [U-Boot] [PATCH v3 3/3] SPL: Change description for spl command Stefano Babic
2012-11-19 10:17 ` Andreas Bießmann [this message]
2012-11-19 10:14 ` [U-Boot] [PATCH v3 1/3] Add README for the "Falcon" mode Otavio Salvador
2012-11-19 10:36 ` Stefano Babic
2012-11-19 10:21 ` Andreas Bießmann
2012-11-19 10:37 ` Stefano Babic
2012-11-23 15:31 ` [U-Boot] [PATCH v4 " Stefano Babic
2012-11-23 15:31 ` [U-Boot] [PATCH v4 2/3] OMAP3: drop CONFIG_SPL_OS_BOOT_KEY and use local define Stefano Babic
2012-11-23 15:31 ` [U-Boot] [PATCH v4 3/3] SPL: Change description for spl command Stefano Babic
2012-11-23 18:10 ` [U-Boot] [PATCH v4 1/3] Add README for the "Falcon" mode Vikram Narayanan
2012-11-23 21:59 ` Andreas Bießmann
2012-11-25 3:47 ` Vikram Narayanan
2012-11-24 14:18 ` Stefano Babic
2013-02-11 21:12 ` [U-Boot] [PATCH] " Otavio Salvador
2013-02-12 8:23 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AA0726.3080809@gmail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.