From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH v2 1/2] ARM: OMAP2+: timer: remove CONFIG_OMAP_32K_TIMER Date: Mon, 19 Nov 2012 16:12:33 +0530 Message-ID: <50AA0D19.8040605@ti.com> References: <1353251201-10990-1-git-send-email-grinberg@compulab.co.il> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:54956 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248Ab2KSKme (ORCPT ); Mon, 19 Nov 2012 05:42:34 -0500 In-Reply-To: <1353251201-10990-1-git-send-email-grinberg@compulab.co.il> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Igor Grinberg Cc: Tony Lindgren , Kevin Hilman , Paul Walmsley , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jon Hunter , Vaibhav Hiremath On Sunday 18 November 2012 08:36 PM, Igor Grinberg wrote: > CONFIG_OMAP_32K_TIMER is kind of standing on the single zImage way. > Make OMAP2+ timer code independant from the CONFIG_OMAP_32K_TIMER > setting. > To remove the dependancy, several conversions/additions had to be done: > 1) Timer initialization functions are named by the platform > name and the clock source in use. > This also makes it possible to define and use the GPTIMER as the > clock source instead of the 32K timer on platforms that do not have > the 32K timer ip block or the 32K timer is not wired on the board. > Cirrently, the the timer is chosen in the machine_desc structure on > per board basis. Later, DT should be used to choose the timer. > 2) Settings under the CONFIG_OMAP_32K_TIMER option are used as defaults > and those under !CONFIG_OMAP_32K_TIMER are removed. > This removes the CONFIG_OMAP_32K_TIMER on OMAP2+ timer code. > 3) Since we have all the timers defined inside machine_desc structure > and we no longer need the fallback to gp_timer clock source in case > 32k_timer clock source is unavailable (namely on AM33xx), we no > longer need the #ifdef around __omap2_sync32k_clocksource_init() > function. Remove the #ifdef CONFIG_OMAP_32K_TIMER around the > __omap2_sync32k_clocksource_init() function. > > Signed-off-by: Igor Grinberg > Cc: Jon Hunter > Cc: Santosh Shilimkar > Cc: Vaibhav Hiremath > --- nice clean-up Igor. Patch looks good to my eyes. Feel free to add , Acked-by: Santosh Shilimkar From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Mon, 19 Nov 2012 16:12:33 +0530 Subject: [PATCH v2 1/2] ARM: OMAP2+: timer: remove CONFIG_OMAP_32K_TIMER In-Reply-To: <1353251201-10990-1-git-send-email-grinberg@compulab.co.il> References: <1353251201-10990-1-git-send-email-grinberg@compulab.co.il> Message-ID: <50AA0D19.8040605@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sunday 18 November 2012 08:36 PM, Igor Grinberg wrote: > CONFIG_OMAP_32K_TIMER is kind of standing on the single zImage way. > Make OMAP2+ timer code independant from the CONFIG_OMAP_32K_TIMER > setting. > To remove the dependancy, several conversions/additions had to be done: > 1) Timer initialization functions are named by the platform > name and the clock source in use. > This also makes it possible to define and use the GPTIMER as the > clock source instead of the 32K timer on platforms that do not have > the 32K timer ip block or the 32K timer is not wired on the board. > Cirrently, the the timer is chosen in the machine_desc structure on > per board basis. Later, DT should be used to choose the timer. > 2) Settings under the CONFIG_OMAP_32K_TIMER option are used as defaults > and those under !CONFIG_OMAP_32K_TIMER are removed. > This removes the CONFIG_OMAP_32K_TIMER on OMAP2+ timer code. > 3) Since we have all the timers defined inside machine_desc structure > and we no longer need the fallback to gp_timer clock source in case > 32k_timer clock source is unavailable (namely on AM33xx), we no > longer need the #ifdef around __omap2_sync32k_clocksource_init() > function. Remove the #ifdef CONFIG_OMAP_32K_TIMER around the > __omap2_sync32k_clocksource_init() function. > > Signed-off-by: Igor Grinberg > Cc: Jon Hunter > Cc: Santosh Shilimkar > Cc: Vaibhav Hiremath > --- nice clean-up Igor. Patch looks good to my eyes. Feel free to add , Acked-by: Santosh Shilimkar