From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Concern about AMD IOMMU HPET msi remapping
Date: Mon, 19 Nov 2012 13:33:19 +0000
Message-ID: <50AA351F.5030301@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <jbeulich@suse.com>, Wei Wang <wei.wang2@amd.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Hello,

In the committed patch
http://xenbits.xen.org/hg/staging/xen-unstable.hg/rev/9025a10c0561

The bdf parameter to update_intremap_entry_from_msi_msg() is declared as
u8.  The single caller of this function passes bdf as an int (which is
only ever filled with a u16), while the this function passes bdf to
get_{dma,intremap}_requestor_id(), which expect u16's

Is there not a truncation issue by doing this, or am I missing something?

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com