Re: [PATCH] xen: restore GNTTABOP_dump_table

["Roger Pau Monné" <roger.pau@citrix.com>]

On 19/11/12 15:29, Ian Campbell wrote:
> On Fri, 2012-11-16 at 15:02 +0000, Roger Pau Monné wrote:
>> On 16/11/12 15:52, David Vrabel wrote:
>>> On 19/10/12 16:47, Roger Pau Monne wrote:
>>>> This operation was dropped long time ago, but I found it quite helpful
>>>> for debugging purposes. This re-implementation uses the code already
>>>> present in gnttab_usage_print and adds the maptrack-table dump.
>>>
>>> Why is the operation useful?  Isn't the debug key sufficient?
>>
>> The debug key doesn't print the maptrack, and also I found it quite
>> useful to be able to call this from the guest kernel itself at certain
>> specific points (like before and after cleaning the list of persistent
>> grants), which is not possible when using the debug key.
> 
> I presume this involved temporarily patching Xen to allow this since you
> wouldn't want this function to be callable by guests in general.

By guest kernel I meant Dom0 kernel, sorry for the confusion. I've
always used the check below to prevent non privileged kernels from
getting this information:

+    if ( !IS_PRIV(current->domain) )
+        return -EPERM;


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel