From: Patrick Lehner <lehner.patrick@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: `git mv` has ambiguous error message for non-existing target
Date: Mon, 19 Nov 2012 22:07:21 +0100 [thread overview]
Message-ID: <50AA9F89.1050401@gmx.de> (raw)
In-Reply-To: <7vpq3cja4y.fsf@alter.siamese.dyndns.org>
On Sa 17 Nov 2012 20:35:09 CET, Junio C Hamano wrote:
> Patrick Lehner <lehner.patrick@gmx.de> writes:
>
>> But just because mv's error essage isnt very good, does that mean git
>> mv's error message mustn't be better?
>
> Did I say the error message from 'mv' was not very good in the
> message you are responding to (by the way, this is why you should
> never top-post when you are responding to a message on this list)?
>
> I meant to say that the message from 'mv' is good enough, so is the
> one given by 'git mv'.
>
> I wouldn't reject a patch that updates our message to something more
> informative without looking at it, though.
I apologize for top-posting -- I don't usually use mailing lists and am
not aware of the usual netiquette.
And yes, I did interpret a bit more into your reply than was there.
I wouldn't call the 'mv' error message "good enough" in this case, but
very well, opinions may very well differ. Unfortunately, I have no time
to get into the git code and contribution guidelines, so I cannot
submit a patch myself. I would appreciate if someone else who shares my
sentiment and knows their way around the git source a bit could find
the time to add this :)
Regards,
Patrick
prev parent reply other threads:[~2012-11-19 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 18:54 `git mv` has ambiguous error message for non-existing target Patrick Lehner
2012-11-16 1:34 ` Junio C Hamano
2012-11-16 7:10 ` Patrick Lehner
2012-11-17 19:35 ` Junio C Hamano
2012-11-19 21:07 ` Patrick Lehner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AA9F89.1050401@gmx.de \
--to=lehner.patrick@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.