From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Priebe Subject: Re: librbd discard bug problems -> i got it Date: Tue, 20 Nov 2012 00:42:03 +0100 Message-ID: <50AAC3CB.9090309@profihost.ag> References: <50AAA25F.9040908@profihost.ag> <50AAB4D6.3030304@inktank.com> <50AABDD1.5050802@profihost.ag> <50AAC1B1.9070701@inktank.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail.profihost.ag ([85.158.179.208]:50203 "EHLO mail.profihost.ag" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751987Ab2KSXmG (ORCPT ); Mon, 19 Nov 2012 18:42:06 -0500 In-Reply-To: <50AAC1B1.9070701@inktank.com> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Josh Durgin Cc: "ceph-devel@vger.kernel.org" Am 20.11.2012 00:33, schrieb Josh Durgin: > On 11/19/2012 03:16 PM, Stefan Priebe wrote: >> mhm qemu rbd block driver. Get's always these errors back. As >> rbd_aio_bh_cb is directly called from librbd the problem must be there. >> Strangely i can't find where rbd_aio_bh_cb get's called with -512. >> >> ANy further ideas? > > Two ideas: > > 1) Is rbd_finish_aiocb getting this same return value? Will check this tomorrow. > 2) Perhaps it's an issue with the return value wrapping around with > very large discards. Adding some logging of the return values of each > rados operation in AioCompletion::complete_request() might give us a > clue. These large negative return values are suspicious. Good idea. As r and rval is int it is limited. But AioCompletion::complete_request is adding more and more stuff to rval. What could be a solution? Bump rval to int64? Or wrap to around to start at 0 again? Stefan